Qt: Capturing images from camera continuously fills the whole memory











up vote
-1
down vote

favorite












I am trying to capture images continuously so I can send them using UDP. I am doing this to implement a live video streaming program.



The code below captures images continuously and assigns images to QGraphicsScene so I can test if images play like a video. But when I run the program my computer freezes even though I delete the pointers. How can I optimize this code ?



#include "mainwindow.h"
#include "ui_mainwindow.h"
#include <QThread>

MainWindow::MainWindow(QWidget *parent) :
QMainWindow(parent),
ui(new Ui::MainWindow)
{
ui->setupUi(this);
scene = new QGraphicsScene(this);
ui->graphicsView->setScene(scene);
cam = new QCamera;
cam->setCaptureMode(QCamera::CaptureStillImage);

viewfinder = new QCameraViewfinder;
viewfinder->show();
QCameraImageCapture *cap = new QCameraImageCapture(cam);
cap->setCaptureDestination(QCameraImageCapture::CaptureToBuffer);

cam->setViewfinder(viewfinder);


QObject::connect(cap, &QCameraImageCapture::imageCaptured, [=] (int id, QImage img) {

while(true){
QByteArray *buf = new QByteArray;
QBuffer *buffer=new QBuffer(buf);
buffer->open(QIODevice::WriteOnly);
img.save(buffer, "BMP");
QPixmap *pixmap = new QPixmap();
pixmap->loadFromData(buffer->buffer());
scene->addPixmap(*pixmap);
delete buf;
delete buffer;
delete pixmap;

QThread::sleep(0.0416);
cap->capture();

}

});

QObject::connect(cap, &QCameraImageCapture::readyForCaptureChanged, [=] (bool state) {
if(state == true) {
cam->searchAndLock();
cap->capture();
cam->unlock();
}
});
cam->start();
}

MainWindow::~MainWindow()
{
delete ui;
}









share|improve this question


























    up vote
    -1
    down vote

    favorite












    I am trying to capture images continuously so I can send them using UDP. I am doing this to implement a live video streaming program.



    The code below captures images continuously and assigns images to QGraphicsScene so I can test if images play like a video. But when I run the program my computer freezes even though I delete the pointers. How can I optimize this code ?



    #include "mainwindow.h"
    #include "ui_mainwindow.h"
    #include <QThread>

    MainWindow::MainWindow(QWidget *parent) :
    QMainWindow(parent),
    ui(new Ui::MainWindow)
    {
    ui->setupUi(this);
    scene = new QGraphicsScene(this);
    ui->graphicsView->setScene(scene);
    cam = new QCamera;
    cam->setCaptureMode(QCamera::CaptureStillImage);

    viewfinder = new QCameraViewfinder;
    viewfinder->show();
    QCameraImageCapture *cap = new QCameraImageCapture(cam);
    cap->setCaptureDestination(QCameraImageCapture::CaptureToBuffer);

    cam->setViewfinder(viewfinder);


    QObject::connect(cap, &QCameraImageCapture::imageCaptured, [=] (int id, QImage img) {

    while(true){
    QByteArray *buf = new QByteArray;
    QBuffer *buffer=new QBuffer(buf);
    buffer->open(QIODevice::WriteOnly);
    img.save(buffer, "BMP");
    QPixmap *pixmap = new QPixmap();
    pixmap->loadFromData(buffer->buffer());
    scene->addPixmap(*pixmap);
    delete buf;
    delete buffer;
    delete pixmap;

    QThread::sleep(0.0416);
    cap->capture();

    }

    });

    QObject::connect(cap, &QCameraImageCapture::readyForCaptureChanged, [=] (bool state) {
    if(state == true) {
    cam->searchAndLock();
    cap->capture();
    cam->unlock();
    }
    });
    cam->start();
    }

    MainWindow::~MainWindow()
    {
    delete ui;
    }









    share|improve this question
























      up vote
      -1
      down vote

      favorite









      up vote
      -1
      down vote

      favorite











      I am trying to capture images continuously so I can send them using UDP. I am doing this to implement a live video streaming program.



      The code below captures images continuously and assigns images to QGraphicsScene so I can test if images play like a video. But when I run the program my computer freezes even though I delete the pointers. How can I optimize this code ?



      #include "mainwindow.h"
      #include "ui_mainwindow.h"
      #include <QThread>

      MainWindow::MainWindow(QWidget *parent) :
      QMainWindow(parent),
      ui(new Ui::MainWindow)
      {
      ui->setupUi(this);
      scene = new QGraphicsScene(this);
      ui->graphicsView->setScene(scene);
      cam = new QCamera;
      cam->setCaptureMode(QCamera::CaptureStillImage);

      viewfinder = new QCameraViewfinder;
      viewfinder->show();
      QCameraImageCapture *cap = new QCameraImageCapture(cam);
      cap->setCaptureDestination(QCameraImageCapture::CaptureToBuffer);

      cam->setViewfinder(viewfinder);


      QObject::connect(cap, &QCameraImageCapture::imageCaptured, [=] (int id, QImage img) {

      while(true){
      QByteArray *buf = new QByteArray;
      QBuffer *buffer=new QBuffer(buf);
      buffer->open(QIODevice::WriteOnly);
      img.save(buffer, "BMP");
      QPixmap *pixmap = new QPixmap();
      pixmap->loadFromData(buffer->buffer());
      scene->addPixmap(*pixmap);
      delete buf;
      delete buffer;
      delete pixmap;

      QThread::sleep(0.0416);
      cap->capture();

      }

      });

      QObject::connect(cap, &QCameraImageCapture::readyForCaptureChanged, [=] (bool state) {
      if(state == true) {
      cam->searchAndLock();
      cap->capture();
      cam->unlock();
      }
      });
      cam->start();
      }

      MainWindow::~MainWindow()
      {
      delete ui;
      }









      share|improve this question













      I am trying to capture images continuously so I can send them using UDP. I am doing this to implement a live video streaming program.



      The code below captures images continuously and assigns images to QGraphicsScene so I can test if images play like a video. But when I run the program my computer freezes even though I delete the pointers. How can I optimize this code ?



      #include "mainwindow.h"
      #include "ui_mainwindow.h"
      #include <QThread>

      MainWindow::MainWindow(QWidget *parent) :
      QMainWindow(parent),
      ui(new Ui::MainWindow)
      {
      ui->setupUi(this);
      scene = new QGraphicsScene(this);
      ui->graphicsView->setScene(scene);
      cam = new QCamera;
      cam->setCaptureMode(QCamera::CaptureStillImage);

      viewfinder = new QCameraViewfinder;
      viewfinder->show();
      QCameraImageCapture *cap = new QCameraImageCapture(cam);
      cap->setCaptureDestination(QCameraImageCapture::CaptureToBuffer);

      cam->setViewfinder(viewfinder);


      QObject::connect(cap, &QCameraImageCapture::imageCaptured, [=] (int id, QImage img) {

      while(true){
      QByteArray *buf = new QByteArray;
      QBuffer *buffer=new QBuffer(buf);
      buffer->open(QIODevice::WriteOnly);
      img.save(buffer, "BMP");
      QPixmap *pixmap = new QPixmap();
      pixmap->loadFromData(buffer->buffer());
      scene->addPixmap(*pixmap);
      delete buf;
      delete buffer;
      delete pixmap;

      QThread::sleep(0.0416);
      cap->capture();

      }

      });

      QObject::connect(cap, &QCameraImageCapture::readyForCaptureChanged, [=] (bool state) {
      if(state == true) {
      cam->searchAndLock();
      cap->capture();
      cam->unlock();
      }
      });
      cam->start();
      }

      MainWindow::~MainWindow()
      {
      delete ui;
      }






      c++ memory-management memory-optimization qt






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked 23 mins ago









      onur cevik

      42




      42



























          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f209764%2fqt-capturing-images-from-camera-continuously-fills-the-whole-memory%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown






























          active

          oldest

          votes













          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes
















          draft saved

          draft discarded




















































          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.





          Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


          Please pay close attention to the following guidance:


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f209764%2fqt-capturing-images-from-camera-continuously-fills-the-whole-memory%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          Quarter-circle Tiles

          build a pushdown automaton that recognizes the reverse language of a given pushdown automaton?

          Mont Emei