Implementing Passport authentication with promises
up vote
0
down vote
favorite
Here is code implementing Passport authentication with a Google Strategy. It uses Mongoose to store and retrieve user data.
You might need to be familiar with both of these technologies to review this code if not check out the two links I provided.
I have included only the Passport file. I was told I am not using promises correctly and would like to rectify this if it is in fact true.
The code is full of comments below. Please let me know if more clarification or context is needed.
Thanks for any feedback.
Passport
const passport = require('passport');
const GoogleStrategy = require('passport-google-oauth').OAuth2Strategy;
const DBM = require('../../database/mongoose');
const helper = require('../../config/helper');
// review this post
// https://stackoverflow.com/questions/50339887/can-i-reduce-this-passport-code
// configure Passport to use Google Auth
passport.use('google', new GoogleStrategy(helper.getPassport(), getOrCreateUser));
// passed to passport, this is the starting point for Google Auth
function getOrCreateUser (accessToken, refreshToken, profile, done) {
// abstracts out relevant information from what Google returns
const user_props = obtainProps(profile);
DBM.getUser(user_props.id_google).then( (res) => {
// res[0] will be "true" if the user exists
return res[0] ? done(null, user_props) : createUser(done, user_props);
}).catch( error => {
return done(error, null);
});
}
// the user was not found, create the user
function createUser (done, user_props) {
DBM.createUser(user_props).then(() => {
return done(null, user_props);
}).catch( error => {
return done(error, null);
});
}
// serializeUser required by passport to identify the user uniquely on the client
passport.serializeUser( (profile, done) => {
done(null, profile.id_google);
});
// deserializeUser required by passport to retrieve data on the server using unique
// identifier created by serializeUser
passport.deserializeUser( (id_google, done) => {
DBM.getUser(id_google).then((res) => {
done(null, res[0]);
}).catch( (error) => {
console.error('DBM.getUser() Error: ', error);
});
});
// takes a profile from Google and extracts parameters to save
function obtainProps (profile) {
let props = {};
props.id_google = profile.id;
props.email = profile.emails[0].value;
props.name = profile.displayName;
props.pic_url = profile.photos[0].value;
props.type = profile._json.objectType;
return props;
}
module.exports = passport;
javascript promise passport
asked 5 mins ago
J.M.
13
New contributor
J.M. is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
up vote
0
down vote
favorite
Here is code implementing Passport authentication with a Google Strategy. It uses Mongoose to store and retrieve user data.
You might need to be familiar with both of these technologies to review this code if not check out the two links I provided.
I have included only the Passport file. I was told I am not using promises correctly and would like to rectify this if it is in fact true.
The code is full of comments below. Please let me know if more clarification or context is needed.
Thanks for any feedback.
Passport
const passport = require('passport');
const GoogleStrategy = require('passport-google-oauth').OAuth2Strategy;
const DBM = require('../../database/mongoose');
const helper = require('../../config/helper');
// review this post
// https://stackoverflow.com/questions/50339887/can-i-reduce-this-passport-code
// configure Passport to use Google Auth
passport.use('google', new GoogleStrategy(helper.getPassport(), getOrCreateUser));
// passed to passport, this is the starting point for Google Auth
function getOrCreateUser (accessToken, refreshToken, profile, done) {
// abstracts out relevant information from what Google returns
const user_props = obtainProps(profile);
DBM.getUser(user_props.id_google).then( (res) => {
// res[0] will be "true" if the user exists
return res[0] ? done(null, user_props) : createUser(done, user_props);
}).catch( error => {
return done(error, null);
});
}
// the user was not found, create the user
function createUser (done, user_props) {
DBM.createUser(user_props).then(() => {
return done(null, user_props);
}).catch( error => {
return done(error, null);
});
}
// serializeUser required by passport to identify the user uniquely on the client
passport.serializeUser( (profile, done) => {
done(null, profile.id_google);
});
// deserializeUser required by passport to retrieve data on the server using unique
// identifier created by serializeUser
passport.deserializeUser( (id_google, done) => {
DBM.getUser(id_google).then((res) => {
done(null, res[0]);
}).catch( (error) => {
console.error('DBM.getUser() Error: ', error);
});
});
// takes a profile from Google and extracts parameters to save
function obtainProps (profile) {
let props = {};
props.id_google = profile.id;
props.email = profile.emails[0].value;
props.name = profile.displayName;
props.pic_url = profile.photos[0].value;
props.type = profile._json.objectType;
return props;
}
module.exports = passport;
javascript promise passport
asked 5 mins ago
J.M.
13
New contributor
J.M. is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
up vote
0
down vote
favorite
up vote
0
down vote
favorite
Here is code implementing Passport authentication with a Google Strategy. It uses Mongoose to store and retrieve user data.
You might need to be familiar with both of these technologies to review this code if not check out the two links I provided.
I have included only the Passport file. I was told I am not using promises correctly and would like to rectify this if it is in fact true.
The code is full of comments below. Please let me know if more clarification or context is needed.
Thanks for any feedback.
Passport
const passport = require('passport');
const GoogleStrategy = require('passport-google-oauth').OAuth2Strategy;
const DBM = require('../../database/mongoose');
const helper = require('../../config/helper');
// review this post
// https://stackoverflow.com/questions/50339887/can-i-reduce-this-passport-code
// configure Passport to use Google Auth
passport.use('google', new GoogleStrategy(helper.getPassport(), getOrCreateUser));
// passed to passport, this is the starting point for Google Auth
function getOrCreateUser (accessToken, refreshToken, profile, done) {
// abstracts out relevant information from what Google returns
const user_props = obtainProps(profile);
DBM.getUser(user_props.id_google).then( (res) => {
// res[0] will be "true" if the user exists
return res[0] ? done(null, user_props) : createUser(done, user_props);
}).catch( error => {
return done(error, null);
});
}
// the user was not found, create the user
function createUser (done, user_props) {
DBM.createUser(user_props).then(() => {
return done(null, user_props);
}).catch( error => {
return done(error, null);
});
}
// serializeUser required by passport to identify the user uniquely on the client
passport.serializeUser( (profile, done) => {
done(null, profile.id_google);
});
// deserializeUser required by passport to retrieve data on the server using unique
// identifier created by serializeUser
passport.deserializeUser( (id_google, done) => {
DBM.getUser(id_google).then((res) => {
done(null, res[0]);
}).catch( (error) => {
console.error('DBM.getUser() Error: ', error);
});
});
// takes a profile from Google and extracts parameters to save
function obtainProps (profile) {
let props = {};
props.id_google = profile.id;
props.email = profile.emails[0].value;
props.name = profile.displayName;
props.pic_url = profile.photos[0].value;
props.type = profile._json.objectType;
return props;
}
module.exports = passport;
javascript promise passport
asked 5 mins ago
J.M.
13
New contributor
J.M. is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
Here is code implementing Passport authentication with a Google Strategy. It uses Mongoose to store and retrieve user data.
You might need to be familiar with both of these technologies to review this code if not check out the two links I provided.
I have included only the Passport file. I was told I am not using promises correctly and would like to rectify this if it is in fact true.
The code is full of comments below. Please let me know if more clarification or context is needed.
Thanks for any feedback.
Passport
const passport = require('passport');
const GoogleStrategy = require('passport-google-oauth').OAuth2Strategy;
const DBM = require('../../database/mongoose');
const helper = require('../../config/helper');
// review this post
// https://stackoverflow.com/questions/50339887/can-i-reduce-this-passport-code
// configure Passport to use Google Auth
passport.use('google', new GoogleStrategy(helper.getPassport(), getOrCreateUser));
// passed to passport, this is the starting point for Google Auth
function getOrCreateUser (accessToken, refreshToken, profile, done) {
// abstracts out relevant information from what Google returns
const user_props = obtainProps(profile);
DBM.getUser(user_props.id_google).then( (res) => {
// res[0] will be "true" if the user exists
return res[0] ? done(null, user_props) : createUser(done, user_props);
}).catch( error => {
return done(error, null);
});
}
// the user was not found, create the user
function createUser (done, user_props) {
DBM.createUser(user_props).then(() => {
return done(null, user_props);
}).catch( error => {
return done(error, null);
});
}
// serializeUser required by passport to identify the user uniquely on the client
passport.serializeUser( (profile, done) => {
done(null, profile.id_google);
});
// deserializeUser required by passport to retrieve data on the server using unique
// identifier created by serializeUser
passport.deserializeUser( (id_google, done) => {
DBM.getUser(id_google).then((res) => {
done(null, res[0]);
}).catch( (error) => {
console.error('DBM.getUser() Error: ', error);
});
});
// takes a profile from Google and extracts parameters to save
function obtainProps (profile) {
let props = {};
props.id_google = profile.id;
props.email = profile.emails[0].value;
props.name = profile.displayName;
props.pic_url = profile.photos[0].value;
props.type = profile._json.objectType;
return props;
}
module.exports = passport;
javascript promise passport
javascript promise passport
asked 5 mins ago
J.M.
13
New contributor
J.M. is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 5 mins ago
J.M.
13
New contributor
J.M. is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 5 mins ago
J.M.
13
New contributor
J.M. is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 5 mins ago
J.M.
13
asked 5 mins ago
J.M.
13
13
New contributor
J.M. is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
J.M. is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
J.M. is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
J.M. is a new contributor. Be nice, and check out our Code of Conduct.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f209795%2fimplementing-passport-authentication-with-promises%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
active
oldest
votes
active
oldest
votes
active
oldest
votes
active
oldest
votes
J.M. is a new contributor. Be nice, and check out our Code of Conduct.
draft saved
draft discarded
J.M. is a new contributor. Be nice, and check out our Code of Conduct.
J.M. is a new contributor. Be nice, and check out our Code of Conduct.
J.M. is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f209795%2fimplementing-passport-authentication-with-promises%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
