Cookie-based currency symbol converter
up vote
-1
down vote
favorite
This code is for a currency symbol converter, The first part checks if there is a cookie named currency and if not creates it and sets 2 variables (variables used because of course php could not read the cookie unless it was reloaded after it was set). The second section is to check the existing cookie if it exists and sets the variables accordingly. The last section uses $_GET to change the cookie and set the variables accordingly.
/* No Cookie (Default Currency GBP) */
if(!isset($_COOKIE['currency'])) {
setcookie(currency, GBP, time() + (86400 * 365), "/");
$currency = "GBP";
$currencyid = "1";
}
/* Set Varible Based On Exsiting Cookie and Change Varibles */
if ($_COOKIE['currency'] == "GBP" ){
$currency = "GBP";
$currencyid = "1";
}
elseif ($_COOKIE['currency'] == "USD" ){
$currency = "USD";
$currencyid = "2";
}
else {}
/* Change Cookie and Change Varibles (Because Check Below Wont Find New Varible of Cookie) */
if (isset($_GET['GBP'])) {
setcookie(currency, GBP, time() + (86400 * 365), "/");
$currency = "GBP";
$currencyid = "1";
}
elseif (isset($_GET['USD'])) {
setcookie(currency, USD, time() + (86400 * 365), "/");
$currency = "USD";
$currencyid = "2";
}
else {}
php
edited 35 mins ago
mdfst13
17.1k52155
asked 55 mins ago
Morgan walton
1
New contributor
Morgan walton is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
up vote
-1
down vote
favorite
This code is for a currency symbol converter, The first part checks if there is a cookie named currency and if not creates it and sets 2 variables (variables used because of course php could not read the cookie unless it was reloaded after it was set). The second section is to check the existing cookie if it exists and sets the variables accordingly. The last section uses $_GET to change the cookie and set the variables accordingly.
/* No Cookie (Default Currency GBP) */
if(!isset($_COOKIE['currency'])) {
setcookie(currency, GBP, time() + (86400 * 365), "/");
$currency = "GBP";
$currencyid = "1";
}
/* Set Varible Based On Exsiting Cookie and Change Varibles */
if ($_COOKIE['currency'] == "GBP" ){
$currency = "GBP";
$currencyid = "1";
}
elseif ($_COOKIE['currency'] == "USD" ){
$currency = "USD";
$currencyid = "2";
}
else {}
/* Change Cookie and Change Varibles (Because Check Below Wont Find New Varible of Cookie) */
if (isset($_GET['GBP'])) {
setcookie(currency, GBP, time() + (86400 * 365), "/");
$currency = "GBP";
$currencyid = "1";
}
elseif (isset($_GET['USD'])) {
setcookie(currency, USD, time() + (86400 * 365), "/");
$currency = "USD";
$currencyid = "2";
}
else {}
php
edited 35 mins ago
mdfst13
17.1k52155
asked 55 mins ago
Morgan walton
1
New contributor
Morgan walton is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
1
Does or doesn't this code work as intended? Because it looks like it might not. Please take a look at the help center, especially the parts about working code being a requirement.
– Mast
36 mins ago
1
On top of that, and I recall having warned you about this, the context of this code is somewhat unclear. What are we looking at, how is it called and why does it exist in the first place? I assume this is part of a function. What does the cookie look like and what's up with all the magic numbers?
– Mast
33 mins ago
add a comment |
up vote
-1
down vote
favorite
up vote
-1
down vote
favorite
This code is for a currency symbol converter, The first part checks if there is a cookie named currency and if not creates it and sets 2 variables (variables used because of course php could not read the cookie unless it was reloaded after it was set). The second section is to check the existing cookie if it exists and sets the variables accordingly. The last section uses $_GET to change the cookie and set the variables accordingly.
/* No Cookie (Default Currency GBP) */
if(!isset($_COOKIE['currency'])) {
setcookie(currency, GBP, time() + (86400 * 365), "/");
$currency = "GBP";
$currencyid = "1";
}
/* Set Varible Based On Exsiting Cookie and Change Varibles */
if ($_COOKIE['currency'] == "GBP" ){
$currency = "GBP";
$currencyid = "1";
}
elseif ($_COOKIE['currency'] == "USD" ){
$currency = "USD";
$currencyid = "2";
}
else {}
/* Change Cookie and Change Varibles (Because Check Below Wont Find New Varible of Cookie) */
if (isset($_GET['GBP'])) {
setcookie(currency, GBP, time() + (86400 * 365), "/");
$currency = "GBP";
$currencyid = "1";
}
elseif (isset($_GET['USD'])) {
setcookie(currency, USD, time() + (86400 * 365), "/");
$currency = "USD";
$currencyid = "2";
}
else {}
php
edited 35 mins ago
mdfst13
17.1k52155
asked 55 mins ago
Morgan walton
1
New contributor
Morgan walton is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
This code is for a currency symbol converter, The first part checks if there is a cookie named currency and if not creates it and sets 2 variables (variables used because of course php could not read the cookie unless it was reloaded after it was set). The second section is to check the existing cookie if it exists and sets the variables accordingly. The last section uses $_GET to change the cookie and set the variables accordingly.
/* No Cookie (Default Currency GBP) */
if(!isset($_COOKIE['currency'])) {
setcookie(currency, GBP, time() + (86400 * 365), "/");
$currency = "GBP";
$currencyid = "1";
}
/* Set Varible Based On Exsiting Cookie and Change Varibles */
if ($_COOKIE['currency'] == "GBP" ){
$currency = "GBP";
$currencyid = "1";
}
elseif ($_COOKIE['currency'] == "USD" ){
$currency = "USD";
$currencyid = "2";
}
else {}
/* Change Cookie and Change Varibles (Because Check Below Wont Find New Varible of Cookie) */
if (isset($_GET['GBP'])) {
setcookie(currency, GBP, time() + (86400 * 365), "/");
$currency = "GBP";
$currencyid = "1";
}
elseif (isset($_GET['USD'])) {
setcookie(currency, USD, time() + (86400 * 365), "/");
$currency = "USD";
$currencyid = "2";
}
else {}
php
php
edited 35 mins ago
mdfst13
17.1k52155
asked 55 mins ago
Morgan walton
1
New contributor
Morgan walton is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
edited 35 mins ago
mdfst13
17.1k52155
asked 55 mins ago
Morgan walton
1
New contributor
Morgan walton is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
edited 35 mins ago
mdfst13
17.1k52155
edited 35 mins ago
mdfst13
17.1k52155
edited 35 mins ago
mdfst13
17.1k52155
17.1k52155
asked 55 mins ago
Morgan walton
1
New contributor
Morgan walton is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 55 mins ago
Morgan walton
1
asked 55 mins ago
Morgan walton
1
1
New contributor
Morgan walton is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
Morgan walton is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
Morgan walton is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
1
Does or doesn't this code work as intended? Because it looks like it might not. Please take a look at the help center, especially the parts about working code being a requirement.
– Mast
36 mins ago
1
On top of that, and I recall having warned you about this, the context of this code is somewhat unclear. What are we looking at, how is it called and why does it exist in the first place? I assume this is part of a function. What does the cookie look like and what's up with all the magic numbers?
– Mast
33 mins ago
add a comment |
1
Does or doesn't this code work as intended? Because it looks like it might not. Please take a look at the help center, especially the parts about working code being a requirement.
– Mast
36 mins ago
1
On top of that, and I recall having warned you about this, the context of this code is somewhat unclear. What are we looking at, how is it called and why does it exist in the first place? I assume this is part of a function. What does the cookie look like and what's up with all the magic numbers?
– Mast
33 mins ago
1
1
Does or doesn't this code work as intended? Because it looks like it might not. Please take a look at the help center, especially the parts about working code being a requirement.
– Mast
36 mins ago
Does or doesn't this code work as intended? Because it looks like it might not. Please take a look at the help center, especially the parts about working code being a requirement.
– Mast
36 mins ago
1
1
On top of that, and I recall having warned you about this, the context of this code is somewhat unclear. What are we looking at, how is it called and why does it exist in the first place? I assume this is part of a function. What does the cookie look like and what's up with all the magic numbers?
– Mast
33 mins ago
On top of that, and I recall having warned you about this, the context of this code is somewhat unclear. What are we looking at, how is it called and why does it exist in the first place? I assume this is part of a function. What does the cookie look like and what's up with all the magic numbers?
– Mast
33 mins ago
add a comment |
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Morgan walton is a new contributor. Be nice, and check out our Code of Conduct.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f209737%2fcookie-based-currency-symbol-converter%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
active
oldest
votes
active
oldest
votes
active
oldest
votes
active
oldest
votes
Morgan walton is a new contributor. Be nice, and check out our Code of Conduct.
draft saved
draft discarded
Morgan walton is a new contributor. Be nice, and check out our Code of Conduct.
Morgan walton is a new contributor. Be nice, and check out our Code of Conduct.
Morgan walton is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f209737%2fcookie-based-currency-symbol-converter%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
1
Does or doesn't this code work as intended? Because it looks like it might not. Please take a look at the help center, especially the parts about working code being a requirement.
– Mast
36 mins ago
1
On top of that, and I recall having warned you about this, the context of this code is somewhat unclear. What are we looking at, how is it called and why does it exist in the first place? I assume this is part of a function. What does the cookie look like and what's up with all the magic numbers?
– Mast
33 mins ago