Python: login system
up vote
1
down vote
favorite
The end result of this is to allow a user to log in and/or register themselves for a dice game. please post some suggestions for improvement.
import pickle
logged_in = False
with open('users.pickle', 'rb') as a_file:
users = pickle.load(a_file)
login_or_signup = input('do you want to login or signup? ')
# sign up (creating new account)
if login_or_signup.lower() == "signup":
create_username = input("enter a new username: ")
create_password = input("enter a new password (Your password cannot be the same as your username !!!!!!!): ")
if create_password in users:
create_password = input("password taken re-enter: ")
users[create_username] = create_password
username = input('please enter username: ')
if username in users:
password = input("enter password: ")
if password == users[username]:
print("access granted")
logged_in = True
else:
print("access denied")
with open("users.pickle", 'wb') as f:
pickle.dump(users, f, pickle.HIGHEST_PROTOCOL)
python
asked 56 mins ago
Krishna
161
New contributor
Krishna is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
up vote
1
down vote
favorite
The end result of this is to allow a user to log in and/or register themselves for a dice game. please post some suggestions for improvement.
import pickle
logged_in = False
with open('users.pickle', 'rb') as a_file:
users = pickle.load(a_file)
login_or_signup = input('do you want to login or signup? ')
# sign up (creating new account)
if login_or_signup.lower() == "signup":
create_username = input("enter a new username: ")
create_password = input("enter a new password (Your password cannot be the same as your username !!!!!!!): ")
if create_password in users:
create_password = input("password taken re-enter: ")
users[create_username] = create_password
username = input('please enter username: ')
if username in users:
password = input("enter password: ")
if password == users[username]:
print("access granted")
logged_in = True
else:
print("access denied")
with open("users.pickle", 'wb') as f:
pickle.dump(users, f, pickle.HIGHEST_PROTOCOL)
python
asked 56 mins ago
Krishna
161
New contributor
Krishna is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
up vote
1
down vote
favorite
up vote
1
down vote
favorite
The end result of this is to allow a user to log in and/or register themselves for a dice game. please post some suggestions for improvement.
import pickle
logged_in = False
with open('users.pickle', 'rb') as a_file:
users = pickle.load(a_file)
login_or_signup = input('do you want to login or signup? ')
# sign up (creating new account)
if login_or_signup.lower() == "signup":
create_username = input("enter a new username: ")
create_password = input("enter a new password (Your password cannot be the same as your username !!!!!!!): ")
if create_password in users:
create_password = input("password taken re-enter: ")
users[create_username] = create_password
username = input('please enter username: ')
if username in users:
password = input("enter password: ")
if password == users[username]:
print("access granted")
logged_in = True
else:
print("access denied")
with open("users.pickle", 'wb') as f:
pickle.dump(users, f, pickle.HIGHEST_PROTOCOL)
python
asked 56 mins ago
Krishna
161
New contributor
Krishna is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
The end result of this is to allow a user to log in and/or register themselves for a dice game. please post some suggestions for improvement.
import pickle
logged_in = False
with open('users.pickle', 'rb') as a_file:
users = pickle.load(a_file)
login_or_signup = input('do you want to login or signup? ')
# sign up (creating new account)
if login_or_signup.lower() == "signup":
create_username = input("enter a new username: ")
create_password = input("enter a new password (Your password cannot be the same as your username !!!!!!!): ")
if create_password in users:
create_password = input("password taken re-enter: ")
users[create_username] = create_password
username = input('please enter username: ')
if username in users:
password = input("enter password: ")
if password == users[username]:
print("access granted")
logged_in = True
else:
print("access denied")
with open("users.pickle", 'wb') as f:
pickle.dump(users, f, pickle.HIGHEST_PROTOCOL)
python
python
asked 56 mins ago
Krishna
161
New contributor
Krishna is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 56 mins ago
Krishna
161
New contributor
Krishna is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 56 mins ago
Krishna
161
New contributor
Krishna is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 56 mins ago
Krishna
161
asked 56 mins ago
Krishna
161
161
New contributor
Krishna is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
Krishna is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
Krishna is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
1 Answer
1
active
oldest
votes
up vote
0
down vote
You are introducing this requirement of not having a password being the same as a username, but the problem is the way you check for it:
create_password = input("enter a new password (Your password cannot be the same as your username !!!!!!!): ")
if create_password in users:
The problem arises when my password matches someone else's username.
I think you meant to just compare create_username with create_password values.
In general, there is rarely a case when you should try writing your own login system except that for learning purposes. You may though improve your current setup by introducing hashing of the passwords, to avoid storing them in plain text: Salt and hash a password in python; as well as more password strength requirements: Checking the strength of a password.
answered 23 mins ago
alecxe
14.6k53377
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Krishna is a new contributor. Be nice, and check out our Code of Conduct.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f209733%2fpython-login-system%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
up vote
0
down vote
You are introducing this requirement of not having a password being the same as a username, but the problem is the way you check for it:
create_password = input("enter a new password (Your password cannot be the same as your username !!!!!!!): ")
if create_password in users:
The problem arises when my password matches someone else's username.
I think you meant to just compare create_username with create_password values.
In general, there is rarely a case when you should try writing your own login system except that for learning purposes. You may though improve your current setup by introducing hashing of the passwords, to avoid storing them in plain text: Salt and hash a password in python; as well as more password strength requirements: Checking the strength of a password.
answered 23 mins ago
alecxe
14.6k53377
add a comment |
up vote
0
down vote
You are introducing this requirement of not having a password being the same as a username, but the problem is the way you check for it:
create_password = input("enter a new password (Your password cannot be the same as your username !!!!!!!): ")
if create_password in users:
The problem arises when my password matches someone else's username.
I think you meant to just compare create_username with create_password values.
In general, there is rarely a case when you should try writing your own login system except that for learning purposes. You may though improve your current setup by introducing hashing of the passwords, to avoid storing them in plain text: Salt and hash a password in python; as well as more password strength requirements: Checking the strength of a password.
answered 23 mins ago
alecxe
14.6k53377
add a comment |
up vote
0
down vote
up vote
0
down vote
You are introducing this requirement of not having a password being the same as a username, but the problem is the way you check for it:
create_password = input("enter a new password (Your password cannot be the same as your username !!!!!!!): ")
if create_password in users:
The problem arises when my password matches someone else's username.
I think you meant to just compare create_username with create_password values.
In general, there is rarely a case when you should try writing your own login system except that for learning purposes. You may though improve your current setup by introducing hashing of the passwords, to avoid storing them in plain text: Salt and hash a password in python; as well as more password strength requirements: Checking the strength of a password.
answered 23 mins ago
alecxe
14.6k53377
You are introducing this requirement of not having a password being the same as a username, but the problem is the way you check for it:
create_password = input("enter a new password (Your password cannot be the same as your username !!!!!!!): ")
if create_password in users:
The problem arises when my password matches someone else's username.
I think you meant to just compare create_username with create_password values.
In general, there is rarely a case when you should try writing your own login system except that for learning purposes. You may though improve your current setup by introducing hashing of the passwords, to avoid storing them in plain text: Salt and hash a password in python; as well as more password strength requirements: Checking the strength of a password.
answered 23 mins ago
alecxe
14.6k53377
answered 23 mins ago
alecxe
14.6k53377
answered 23 mins ago
alecxe
14.6k53377
answered 23 mins ago
alecxe
14.6k53377
14.6k53377
add a comment |
add a comment |
Krishna is a new contributor. Be nice, and check out our Code of Conduct.
Krishna is a new contributor. Be nice, and check out our Code of Conduct.
Krishna is a new contributor. Be nice, and check out our Code of Conduct.
Krishna is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f209733%2fpython-login-system%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
