Krdytkyu

I am currently programming a multi processing tool with a GUI in JavaFx. I want to have your opinion about my code.

This is code snippet from my main class:

CountDownLatch latch = new CountDownLatch(selectedPaths.size());

ExecutorService executorService = Executors.newFixedThreadPool(2);

Converter converter = new Converter(parentApp.getMainController(), configuration, dbUtilSC, latch);



//Searching for all zip files and sorting according to directory

for (Path tracePath : selectedPaths) {

    //progress++;

    //updateProgress(progress, selectedPaths.size());



    final List<Path> foundTraces = new ArrayList<>();



    Files.list(tracePath).filter(f -> f.toString().contains("zip")).sorted().forEach(foundTraces::add);



    //Checks for traces in xoraya directory

    if (foundTraces.size() == 0) {

        continue;

    }



    converter = new Converter(foundTraces);



    //converter.getTraceFiles(foundTraces);

    //Converter converter = new Converter(foundTraces, parentApp.getMainController(),

    //configuration, dbUtilSC, latch, pgConvertTraces,selectedPaths.size());



    executorService.execute(converter.runnableTask);



    Thread.sleep(1000);

}



try {

    latch.await();

    executorService.shutdown();



    if (!executorService.awaitTermination(800, TimeUnit.MILLISECONDS)) {

        executorService.shutdownNow();

    }

} catch (InterruptedException e) {

    addLog(e.getMessage(), Level.ERROR);

    executorService.shutdownNow();

}

This is the Convert class which executes the process of converting:

import de.XXX.XXX.XXX.XXX.MainWindowController;

import de.XXX.XXX.XXX.logging.Level;



import java.io.IOException;

import java.nio.file.Files;

import java.nio.file.Path;

import java.nio.file.Paths;

import java.util.List;

import java.util.concurrent.CountDownLatch;



public class Converter implements Runnable {



    private List<Path> traceFiles;

    private int offlineId;

    static private MainWindowController controller;

    static private Configuration configuration;

    static private DatabaseUtil dbUtilSC;

    static private CountDownLatch latch;



    public Runnable runnableTask = () -> {

        try {



            //Gets the path to xoraya directory

            final String xorayaDirectory = traceFiles.get(0).getParent().toString();



            //Double check if folder is already converted

            offlineId = dbUtilSC.getOfflineTraceId(xorayaDirectory);



            //True if xoraya directory is not in DB

            if (offlineId == -1) {



                controller.logToSearchConvert("Found new traces in: " + xorayaDirectory, Level.INFO);



                //Inserts path to xoraya into DB and gives it unique offline trace ID

                dbUtilSC.insertOfflineTraceFile(xorayaDirectory);



                //Gets offline trace ID

                offlineId = dbUtilSC.getOfflineTraceId(xorayaDirectory);



                //Destination directory of the converted trace files

                final Path destinationDir = Paths.get(Global.getTraceAnalyse().toString(), "IncomingTraces",

                        String.valueOf(offlineId));



                createDirectory(destinationDir);



                controller.logToSearchConvert("Processing all trace files in Path: " + destinationDir, Level.INFO);



                final PythonScriptWriter pythonScripter = new PythonScriptWriter(traceFiles,

                        destinationDir.toString(), controller);



                //Writes a python script for the LogFileConverter.exe

                pythonScripter.createPythonScript();



                //Converts all traces in 'outerList' and puts them into 'destinationDir'

                final int errCode = extractTraces(configuration.getPathToLFC(), pythonScripter.getScriptPath());



                //TODO: Check if traces are converted in '/converted' directory

                if (errCode != 0) {

                    //Extracting Traces from .zip Files did not succeed.

                    //All failed extractions get -1 status

                    dbUtilSC.setOfflineTraceStatus(offlineId, -1);



                    controller.logToSearchConvert("Error occurred while extracting traces in path: " + destinationDir

                            , Level.ERROR);

                }

            } else {

                controller.logToSearchConvert("Skipping " + xorayaDirectory, Level.INFO);

            }

        } catch (Exception e) {

            controller.logToSearchConvert(e.getMessage(),Level.ERROR);

        } finally {

            latch.countDown();

            Thread.currentThread().interrupt();

        }

    };



    public Converter(final MainWindowController controller, final Configuration configuration

            , final DatabaseUtil databaseUtil, final CountDownLatch latch) {



        Converter.controller = controller;

        Converter.configuration = configuration;

        Converter.dbUtilSC = databaseUtil;

        Converter.latch = latch;

    }



    public Converter(final List<Path> foundTraces){

        this.traceFiles = foundTraces;

    }



    public void run() {

        this.runnableTask.run();

    }



    private void createDirectory(Path pathToDirectory) {

        try {

            if (!Files.exists(pathToDirectory)) {

                Files.createDirectories(pathToDirectory);

                controller.logToSearchConvert("Created directory with offlineId: " + pathToDirectory.getFileName(),

                        Level.INFO);

            } else {

                controller.logToSearchConvert("Directories with offlineId: " + pathToDirectory.getFileName()

                        + " already existed", Level.WARN);

            }

        } catch (final IOException e) {

            controller.logToSearchConvert(e.getMessage(), Level.ERROR);

        }

    }



    private int extractTraces(final String pathToTopEd, final String pathToPythonScript) {

        int errCode = 0;



        try {

            final ProcessBuilder processBuilder = new ProcessBuilder(Paths.get(pathToTopEd, "TopEd.exe").toString(),

                    "/hidden", "/L", "/LFC", "/script", pathToPythonScript);



            final Process process = processBuilder.start();

            errCode = process.waitFor();



            final int finalErrCode = errCode;

            controller.logToSearchConvert("extractTraces Command executed for OfflineId " + offlineId + ", any errors?"

                    + " " + (finalErrCode == 0 ? "No"

                    : "Yes"), Level.WARN);



        } catch (final IOException | InterruptedException e) {

            controller.logToSearchConvert(e.getMessage(), Level.ERROR);

        }

        return errCode;

    }



}