Powerset of collection in Clojure
up vote
1
down vote
favorite
Similar to this question, here's another implementation. Assume the input is already a set.
(defn powerset
[set]
(reduce
(fn [xs x] (concat xs (map #(cons x %) xs)))
[()]
set))
clojure set
edited 1 hour ago
Jamal♦
30.2k11115226
asked 1 hour ago
dimid
20116
add a comment |
up vote
1
down vote
favorite
Similar to this question, here's another implementation. Assume the input is already a set.
(defn powerset
[set]
(reduce
(fn [xs x] (concat xs (map #(cons x %) xs)))
[()]
set))
clojure set
edited 1 hour ago
Jamal♦
30.2k11115226
asked 1 hour ago
dimid
20116
add a comment |
up vote
1
down vote
favorite
up vote
1
down vote
favorite
Similar to this question, here's another implementation. Assume the input is already a set.
(defn powerset
[set]
(reduce
(fn [xs x] (concat xs (map #(cons x %) xs)))
[()]
set))
clojure set
edited 1 hour ago
Jamal♦
30.2k11115226
asked 1 hour ago
dimid
20116
Similar to this question, here's another implementation. Assume the input is already a set.
(defn powerset
[set]
(reduce
(fn [xs x] (concat xs (map #(cons x %) xs)))
[()]
set))
clojure set
clojure set
edited 1 hour ago
Jamal♦
30.2k11115226
asked 1 hour ago
dimid
20116
edited 1 hour ago
Jamal♦
30.2k11115226
asked 1 hour ago
dimid
20116
edited 1 hour ago
Jamal♦
30.2k11115226
edited 1 hour ago
Jamal♦
30.2k11115226
edited 1 hour ago
Jamal♦
30.2k11115226
30.2k11115226
asked 1 hour ago
dimid
20116
asked 1 hour ago
dimid
20116
asked 1 hour ago
dimid
20116
20116
add a comment |
add a comment |
1 Answer
1
active
oldest
votes
up vote
0
down vote
There isn't a whole lot here to comment on. I'll just mention a few things:
Technically, from my quick search of what a powerset is, this function should return sets. That seems petty, but unless it's documented to return a lazy list of lazy lists, users may try to treat the "subsets" as sets (like using them as functions). I'd finish this function off by
mappingsetover the list.But to do that, you should rename your parameter, as you're shadowing the build-in
set.After doing the above two, it developed quite long lines and became nested. I'd add in some use of
->>, and put a few of the lines on the next line.
After that, I ended up with:
(defn powerset [base-set]
(->> base-set
(reduce
(fn [xs x]
(concat xs
(map #(cons x %) xs)))
[()])
(map set)))
answered 30 mins ago
Carcigenicate
2,68311229
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f209743%2fpowerset-of-collection-in-clojure%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
up vote
0
down vote
There isn't a whole lot here to comment on. I'll just mention a few things:
Technically, from my quick search of what a powerset is, this function should return sets. That seems petty, but unless it's documented to return a lazy list of lazy lists, users may try to treat the "subsets" as sets (like using them as functions). I'd finish this function off by
mappingsetover the list.But to do that, you should rename your parameter, as you're shadowing the build-in
set.After doing the above two, it developed quite long lines and became nested. I'd add in some use of
->>, and put a few of the lines on the next line.
After that, I ended up with:
(defn powerset [base-set]
(->> base-set
(reduce
(fn [xs x]
(concat xs
(map #(cons x %) xs)))
[()])
(map set)))
answered 30 mins ago
Carcigenicate
2,68311229
add a comment |
up vote
0
down vote
There isn't a whole lot here to comment on. I'll just mention a few things:
Technically, from my quick search of what a powerset is, this function should return sets. That seems petty, but unless it's documented to return a lazy list of lazy lists, users may try to treat the "subsets" as sets (like using them as functions). I'd finish this function off by
mappingsetover the list.But to do that, you should rename your parameter, as you're shadowing the build-in
set.After doing the above two, it developed quite long lines and became nested. I'd add in some use of
->>, and put a few of the lines on the next line.
After that, I ended up with:
(defn powerset [base-set]
(->> base-set
(reduce
(fn [xs x]
(concat xs
(map #(cons x %) xs)))
[()])
(map set)))
answered 30 mins ago
Carcigenicate
2,68311229
add a comment |
up vote
0
down vote
up vote
0
down vote
There isn't a whole lot here to comment on. I'll just mention a few things:
Technically, from my quick search of what a powerset is, this function should return sets. That seems petty, but unless it's documented to return a lazy list of lazy lists, users may try to treat the "subsets" as sets (like using them as functions). I'd finish this function off by
mappingsetover the list.But to do that, you should rename your parameter, as you're shadowing the build-in
set.After doing the above two, it developed quite long lines and became nested. I'd add in some use of
->>, and put a few of the lines on the next line.
After that, I ended up with:
(defn powerset [base-set]
(->> base-set
(reduce
(fn [xs x]
(concat xs
(map #(cons x %) xs)))
[()])
(map set)))
answered 30 mins ago
Carcigenicate
2,68311229
There isn't a whole lot here to comment on. I'll just mention a few things:
Technically, from my quick search of what a powerset is, this function should return sets. That seems petty, but unless it's documented to return a lazy list of lazy lists, users may try to treat the "subsets" as sets (like using them as functions). I'd finish this function off by
mappingsetover the list.But to do that, you should rename your parameter, as you're shadowing the build-in
set.After doing the above two, it developed quite long lines and became nested. I'd add in some use of
->>, and put a few of the lines on the next line.
After that, I ended up with:
(defn powerset [base-set]
(->> base-set
(reduce
(fn [xs x]
(concat xs
(map #(cons x %) xs)))
[()])
(map set)))
answered 30 mins ago
Carcigenicate
2,68311229
answered 30 mins ago
Carcigenicate
2,68311229
answered 30 mins ago
Carcigenicate
2,68311229
answered 30 mins ago
Carcigenicate
2,68311229
2,68311229
add a comment |
add a comment |
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f209743%2fpowerset-of-collection-in-clojure%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
