Counting the ones in the binary representation of a number in C# [on hold]











up vote
-1
down vote

favorite












I want to count the 1s in the binary representation of a number (input) in C#.



Which is more readable:



Enumerable

   .Range(0, 32)

   .Aggregate(0, (acc, i) => acc + ((input >> i) & 1));


or



Convert.ToString(input, 2).Count(x => x == '1');





c# comparative-review linq







share|improve this question















put on hold as off-topic by t3chb0t, Toby Speight, IEatBagels, Mast, Ismael Miguel 20 hours ago


This question appears to be off-topic. The users who voted to close gave this specific reason:


  • "Lacks concrete context: Code Review requires concrete code from a project, with sufficient context for reviewers to understand how that code is used. Pseudocode, stub code, hypothetical code, obfuscated code, and generic best practices are outside the scope of this site." – t3chb0t, Toby Speight, IEatBagels, Mast

If this question can be reworded to fit the rules in the help center, please edit the question.













  • Why the downvote?
    – K. Gkinis
    yesterday






  • 1




    I can't speak for the person that downvoted, but your question is getting some close-votes for 'lack of context' - it would help to know in what context this code is used. Either way, I'd say that the more readable solution is to encapsulate this logic in a BitCount(int input) method. Not only does it make the intent clearer at call-sites, it also allows you to swap for a more efficient approach if the need arises.
    – Pieter Witvoet
    23 hours ago










  • Unfortunately, there is no better context. It's not actual code, it's more of an argument over readability over an exercise, so maybe it's too broad.
    – K. Gkinis
    21 hours ago















up vote
-1
down vote

favorite












I want to count the 1s in the binary representation of a number (input) in C#.



Which is more readable:



Enumerable

   .Range(0, 32)

   .Aggregate(0, (acc, i) => acc + ((input >> i) & 1));


or



Convert.ToString(input, 2).Count(x => x == '1');





c# comparative-review linq







share|improve this question















put on hold as off-topic by t3chb0t, Toby Speight, IEatBagels, Mast, Ismael Miguel 20 hours ago


This question appears to be off-topic. The users who voted to close gave this specific reason:


  • "Lacks concrete context: Code Review requires concrete code from a project, with sufficient context for reviewers to understand how that code is used. Pseudocode, stub code, hypothetical code, obfuscated code, and generic best practices are outside the scope of this site." – t3chb0t, Toby Speight, IEatBagels, Mast

If this question can be reworded to fit the rules in the help center, please edit the question.













  • Why the downvote?
    – K. Gkinis
    yesterday






  • 1




    I can't speak for the person that downvoted, but your question is getting some close-votes for 'lack of context' - it would help to know in what context this code is used. Either way, I'd say that the more readable solution is to encapsulate this logic in a BitCount(int input) method. Not only does it make the intent clearer at call-sites, it also allows you to swap for a more efficient approach if the need arises.
    – Pieter Witvoet
    23 hours ago










  • Unfortunately, there is no better context. It's not actual code, it's more of an argument over readability over an exercise, so maybe it's too broad.
    – K. Gkinis
    21 hours ago













up vote
-1
down vote

favorite









up vote
-1
down vote

favorite











I want to count the 1s in the binary representation of a number (input) in C#.



Which is more readable:



Enumerable

   .Range(0, 32)

   .Aggregate(0, (acc, i) => acc + ((input >> i) & 1));


or



Convert.ToString(input, 2).Count(x => x == '1');





c# comparative-review linq







share|improve this question















I want to count the 1s in the binary representation of a number (input) in C#.



Which is more readable:



Enumerable

   .Range(0, 32)

   .Aggregate(0, (acc, i) => acc + ((input >> i) & 1));


or



Convert.ToString(input, 2).Count(x => x == '1');





c# comparative-review linq




c# comparative-review linq






share|improve this question















share|improve this question













share|improve this question




share|improve this question








edited yesterday









200_success

127k15149412




127k15149412










asked yesterday









K. Gkinis

1175




1175




put on hold as off-topic by t3chb0t, Toby Speight, IEatBagels, Mast, Ismael Miguel 20 hours ago


This question appears to be off-topic. The users who voted to close gave this specific reason:


  • "Lacks concrete context: Code Review requires concrete code from a project, with sufficient context for reviewers to understand how that code is used. Pseudocode, stub code, hypothetical code, obfuscated code, and generic best practices are outside the scope of this site." – t3chb0t, Toby Speight, IEatBagels, Mast

If this question can be reworded to fit the rules in the help center, please edit the question.




put on hold as off-topic by t3chb0t, Toby Speight, IEatBagels, Mast, Ismael Miguel 20 hours ago


This question appears to be off-topic. The users who voted to close gave this specific reason:


  • "Lacks concrete context: Code Review requires concrete code from a project, with sufficient context for reviewers to understand how that code is used. Pseudocode, stub code, hypothetical code, obfuscated code, and generic best practices are outside the scope of this site." – t3chb0t, Toby Speight, IEatBagels, Mast

If this question can be reworded to fit the rules in the help center, please edit the question.












  • Why the downvote?
    – K. Gkinis
    yesterday






  • 1




    I can't speak for the person that downvoted, but your question is getting some close-votes for 'lack of context' - it would help to know in what context this code is used. Either way, I'd say that the more readable solution is to encapsulate this logic in a BitCount(int input) method. Not only does it make the intent clearer at call-sites, it also allows you to swap for a more efficient approach if the need arises.
    – Pieter Witvoet
    23 hours ago










  • Unfortunately, there is no better context. It's not actual code, it's more of an argument over readability over an exercise, so maybe it's too broad.
    – K. Gkinis
    21 hours ago


















  • Why the downvote?
    – K. Gkinis
    yesterday






  • 1




    I can't speak for the person that downvoted, but your question is getting some close-votes for 'lack of context' - it would help to know in what context this code is used. Either way, I'd say that the more readable solution is to encapsulate this logic in a BitCount(int input) method. Not only does it make the intent clearer at call-sites, it also allows you to swap for a more efficient approach if the need arises.
    – Pieter Witvoet
    23 hours ago










  • Unfortunately, there is no better context. It's not actual code, it's more of an argument over readability over an exercise, so maybe it's too broad.
    – K. Gkinis
    21 hours ago
















Why the downvote?
– K. Gkinis
yesterday




Why the downvote?
– K. Gkinis
yesterday




1




1




I can't speak for the person that downvoted, but your question is getting some close-votes for 'lack of context' - it would help to know in what context this code is used. Either way, I'd say that the more readable solution is to encapsulate this logic in a BitCount(int input) method. Not only does it make the intent clearer at call-sites, it also allows you to swap for a more efficient approach if the need arises.
– Pieter Witvoet
23 hours ago




I can't speak for the person that downvoted, but your question is getting some close-votes for 'lack of context' - it would help to know in what context this code is used. Either way, I'd say that the more readable solution is to encapsulate this logic in a BitCount(int input) method. Not only does it make the intent clearer at call-sites, it also allows you to swap for a more efficient approach if the need arises.
– Pieter Witvoet
23 hours ago












Unfortunately, there is no better context. It's not actual code, it's more of an argument over readability over an exercise, so maybe it's too broad.
– K. Gkinis
21 hours ago




Unfortunately, there is no better context. It's not actual code, it's more of an argument over readability over an exercise, so maybe it's too broad.
– K. Gkinis
21 hours ago















active

oldest

votes






















active

oldest

votes













active

oldest

votes









active

oldest

votes






active

oldest

votes

-

Popular posts from this blog

Ellipse (mathématiques)

Image
Pour les articles homonymes, voir Ellipse. L'ellipse est le lieu des points dont la somme des distances à deux points fixes, dits foyers, est constante. Section du cône ou projection du cercle. En géométrie, une ellipse est une courbe plane fermée obtenue par l’intersection d’un cône de révolution avec un plan, à condition que celui-ci coupe l'axe de rotation du cône ou du cylindre : c'est une conique d'excentricité strictement comprise entre 0 et 1. On peut également la définir comme le lieu des points dont la somme des distances à deux points fixes, dits foyers, est constante (sa construction par la méthode du jardinier est très simple). Dans la vie courante, l’ellipse est la forme qu'on perçoit en regardant un cercle en perspective, ou la figure formée par l’ombre d'un disque sur une surface plane. On retrouve aussi, en première approximation [ 1 ] , des ellipses dans les trajectoires des corps célestes (planètes, comètes ou satellites arti...
Read more

Quarter-circle Tiles

Image
up vote 0 down vote favorite I have $99$ identical square tiles, each with a quarter-circle drawn on it like this: [asy] size(1.5cm); draw(Arc((2,0),1,90,180),red+1); draw((0,0)--(2,0)--(2,2)--(0,2)--(0,0)); [/asy] When I arrange the tiles in a $9times 11$ rectangular grid, each with a random orientation, what is the expected value of the number of full circles I form? I think this problem has to do with finding the chance any given 2x2 square has a circle, but I can't find it. expected-value share | cite | improve this question asked Nov 20 at 15:03 6minecraftninja 1 2 ...
Read more

Mont Emei

Image
Mont Emei.mw-parser-output .entete.map{background-image:url("//upload.wikimedia.org/wikipedia/commons/7/7a/Picto_infobox_map.png")} Vue du sommet Wanfo du mont Emei Géographie Altitude 3 099  m , Wanfo Coordonnées 29° 31′ 11″ nord, 103° 19′ 57″ est Administration Pays   Chine Province Sichuan Ville-préfecture Leshan Géolocalisation sur la carte : Sichuan Mont Emei Géolocalisation sur la carte : Chine Mont Emei modifier   Paysage panoramique du mont Emei, incluant le paysage panoramique du grand Bouddha de Leshan *   Patrimoine mondial de l'UNESCO Passerelle en bois sur le versant ouest Pays   Chine Subdivision Sichuan Type Mixte Critères (iv) (vi) (x) Superficie 15 400 ha Numéro d’identification 779 Zone géographique Asie et Pacifique  ** Année d’inscription 1996 (20 e session) * Descriptif officiel UNESCO ** Classification géog...
Read more