Count the number of occurrences of each symbol in a string array











up vote
-1
down vote

favorite












This calculates the number of occurrences of each symbol in a string array.



I want to find some places in this multithreading code which could lead to a NullPointerException or other exceptions or vulnerabilities.



public class StringCount extends RecursiveTask<Map<Character, Integer>> {
private int UNIT_SIZE = 1;
private String values;
private int startPos, endPos;

public StringCount(String values) {
this(values, 0, values.length);
}

public StringCount(String values, int startPos, int endPos) {
this.values = values;
this.startPos = startPos;
this.endPos = endPos;
}

protected Map<Character, Integer> compute() {
final int currentSize = endPos - startPos;
if (currentSize <= UNIT_SIZE) {
return computeSum();
}
else {
int center = currentSize / 2;
int leftEnd = startPos + center;
StringCount leftSum = new StringCount(values, startPos, leftEnd);
leftSum.fork();
int rightStart = startPos + center;
StringCount rightSum = new StringCount(values, rightStart, endPos);
Map<Character, Integer> map = rightSum.compute();
Map<Character, Integer> map1 = leftSum.join();
for (Character character : map1.keySet()) {
if (!map.containsKey(character))
map.put(character, 0);
map.put(character, map1.get(character) + map.get(character));
}
return map;
}
}

private Map<Character, Integer> computeSum() {
Map<Character, Integer> map = new HashMap<>();
for (int i = startPos; i < endPos; i++) {
if (values[i] == null) break;
for (int j = 0; j < values[i].length(); j++) {
Character c = values[i].toLowerCase().charAt(j);
if (!map.containsKey(c)) map.put(c, 0);
map.put(c, map.get(c) + 1);
}
}
if (map.size() == 0)map.put(' ', 0);
return map;
}

public static void main(String args) {
String stringArray = new String[100];
for (int i = 0; i < stringArray.length; i++) {
stringArray[i] = "ldlihnvlCdnfcs;dgnhreieue tr;srdrgy rfguhy.";
}
ForkJoinPool pool = new ForkJoinPool();
StringCount calculator = new StringCount(stringArray);
System.out.println(pool.invoke(calculator));
}
}









share|improve this question









New contributor




Vadim is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
























    up vote
    -1
    down vote

    favorite












    This calculates the number of occurrences of each symbol in a string array.



    I want to find some places in this multithreading code which could lead to a NullPointerException or other exceptions or vulnerabilities.



    public class StringCount extends RecursiveTask<Map<Character, Integer>> {
    private int UNIT_SIZE = 1;
    private String values;
    private int startPos, endPos;

    public StringCount(String values) {
    this(values, 0, values.length);
    }

    public StringCount(String values, int startPos, int endPos) {
    this.values = values;
    this.startPos = startPos;
    this.endPos = endPos;
    }

    protected Map<Character, Integer> compute() {
    final int currentSize = endPos - startPos;
    if (currentSize <= UNIT_SIZE) {
    return computeSum();
    }
    else {
    int center = currentSize / 2;
    int leftEnd = startPos + center;
    StringCount leftSum = new StringCount(values, startPos, leftEnd);
    leftSum.fork();
    int rightStart = startPos + center;
    StringCount rightSum = new StringCount(values, rightStart, endPos);
    Map<Character, Integer> map = rightSum.compute();
    Map<Character, Integer> map1 = leftSum.join();
    for (Character character : map1.keySet()) {
    if (!map.containsKey(character))
    map.put(character, 0);
    map.put(character, map1.get(character) + map.get(character));
    }
    return map;
    }
    }

    private Map<Character, Integer> computeSum() {
    Map<Character, Integer> map = new HashMap<>();
    for (int i = startPos; i < endPos; i++) {
    if (values[i] == null) break;
    for (int j = 0; j < values[i].length(); j++) {
    Character c = values[i].toLowerCase().charAt(j);
    if (!map.containsKey(c)) map.put(c, 0);
    map.put(c, map.get(c) + 1);
    }
    }
    if (map.size() == 0)map.put(' ', 0);
    return map;
    }

    public static void main(String args) {
    String stringArray = new String[100];
    for (int i = 0; i < stringArray.length; i++) {
    stringArray[i] = "ldlihnvlCdnfcs;dgnhreieue tr;srdrgy rfguhy.";
    }
    ForkJoinPool pool = new ForkJoinPool();
    StringCount calculator = new StringCount(stringArray);
    System.out.println(pool.invoke(calculator));
    }
    }









    share|improve this question









    New contributor




    Vadim is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.






















      up vote
      -1
      down vote

      favorite









      up vote
      -1
      down vote

      favorite











      This calculates the number of occurrences of each symbol in a string array.



      I want to find some places in this multithreading code which could lead to a NullPointerException or other exceptions or vulnerabilities.



      public class StringCount extends RecursiveTask<Map<Character, Integer>> {
      private int UNIT_SIZE = 1;
      private String values;
      private int startPos, endPos;

      public StringCount(String values) {
      this(values, 0, values.length);
      }

      public StringCount(String values, int startPos, int endPos) {
      this.values = values;
      this.startPos = startPos;
      this.endPos = endPos;
      }

      protected Map<Character, Integer> compute() {
      final int currentSize = endPos - startPos;
      if (currentSize <= UNIT_SIZE) {
      return computeSum();
      }
      else {
      int center = currentSize / 2;
      int leftEnd = startPos + center;
      StringCount leftSum = new StringCount(values, startPos, leftEnd);
      leftSum.fork();
      int rightStart = startPos + center;
      StringCount rightSum = new StringCount(values, rightStart, endPos);
      Map<Character, Integer> map = rightSum.compute();
      Map<Character, Integer> map1 = leftSum.join();
      for (Character character : map1.keySet()) {
      if (!map.containsKey(character))
      map.put(character, 0);
      map.put(character, map1.get(character) + map.get(character));
      }
      return map;
      }
      }

      private Map<Character, Integer> computeSum() {
      Map<Character, Integer> map = new HashMap<>();
      for (int i = startPos; i < endPos; i++) {
      if (values[i] == null) break;
      for (int j = 0; j < values[i].length(); j++) {
      Character c = values[i].toLowerCase().charAt(j);
      if (!map.containsKey(c)) map.put(c, 0);
      map.put(c, map.get(c) + 1);
      }
      }
      if (map.size() == 0)map.put(' ', 0);
      return map;
      }

      public static void main(String args) {
      String stringArray = new String[100];
      for (int i = 0; i < stringArray.length; i++) {
      stringArray[i] = "ldlihnvlCdnfcs;dgnhreieue tr;srdrgy rfguhy.";
      }
      ForkJoinPool pool = new ForkJoinPool();
      StringCount calculator = new StringCount(stringArray);
      System.out.println(pool.invoke(calculator));
      }
      }









      share|improve this question









      New contributor




      Vadim is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.











      This calculates the number of occurrences of each symbol in a string array.



      I want to find some places in this multithreading code which could lead to a NullPointerException or other exceptions or vulnerabilities.



      public class StringCount extends RecursiveTask<Map<Character, Integer>> {
      private int UNIT_SIZE = 1;
      private String values;
      private int startPos, endPos;

      public StringCount(String values) {
      this(values, 0, values.length);
      }

      public StringCount(String values, int startPos, int endPos) {
      this.values = values;
      this.startPos = startPos;
      this.endPos = endPos;
      }

      protected Map<Character, Integer> compute() {
      final int currentSize = endPos - startPos;
      if (currentSize <= UNIT_SIZE) {
      return computeSum();
      }
      else {
      int center = currentSize / 2;
      int leftEnd = startPos + center;
      StringCount leftSum = new StringCount(values, startPos, leftEnd);
      leftSum.fork();
      int rightStart = startPos + center;
      StringCount rightSum = new StringCount(values, rightStart, endPos);
      Map<Character, Integer> map = rightSum.compute();
      Map<Character, Integer> map1 = leftSum.join();
      for (Character character : map1.keySet()) {
      if (!map.containsKey(character))
      map.put(character, 0);
      map.put(character, map1.get(character) + map.get(character));
      }
      return map;
      }
      }

      private Map<Character, Integer> computeSum() {
      Map<Character, Integer> map = new HashMap<>();
      for (int i = startPos; i < endPos; i++) {
      if (values[i] == null) break;
      for (int j = 0; j < values[i].length(); j++) {
      Character c = values[i].toLowerCase().charAt(j);
      if (!map.containsKey(c)) map.put(c, 0);
      map.put(c, map.get(c) + 1);
      }
      }
      if (map.size() == 0)map.put(' ', 0);
      return map;
      }

      public static void main(String args) {
      String stringArray = new String[100];
      for (int i = 0; i < stringArray.length; i++) {
      stringArray[i] = "ldlihnvlCdnfcs;dgnhreieue tr;srdrgy rfguhy.";
      }
      ForkJoinPool pool = new ForkJoinPool();
      StringCount calculator = new StringCount(stringArray);
      System.out.println(pool.invoke(calculator));
      }
      }






      java concurrency exception






      share|improve this question









      New contributor




      Vadim is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.











      share|improve this question









      New contributor




      Vadim is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      share|improve this question




      share|improve this question








      edited yesterday









      Graipher

      23k53384




      23k53384






      New contributor




      Vadim is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked yesterday









      Vadim

      1




      1




      New contributor




      Vadim is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      Vadim is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      Vadim is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.



























          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });






          Vadim is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f209158%2fcount-the-number-of-occurrences-of-each-symbol-in-a-string-array%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown






























          active

          oldest

          votes













          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          Vadim is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          Vadim is a new contributor. Be nice, and check out our Code of Conduct.













          Vadim is a new contributor. Be nice, and check out our Code of Conduct.












          Vadim is a new contributor. Be nice, and check out our Code of Conduct.
















          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.





          Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


          Please pay close attention to the following guidance:


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f209158%2fcount-the-number-of-occurrences-of-each-symbol-in-a-string-array%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          Quarter-circle Tiles

          build a pushdown automaton that recognizes the reverse language of a given pushdown automaton?

          Mont Emei