solidity ^0.5.0 factory pattern mapping apprach
new to solidity.
Trying to understand the better approach for using a mapping storage in factory contract.
2 options:
- Use
mapping(address => Contract)
- Use
mapping(address => address)
Sample factory:
contract CampaignFactory {
mapping(address => Campaign) campaigns;
function createCampaign(uint min_contrib) public {
Campaign newCampaign = new Campaign(min_contrib, msg.sender);
campaigns[msg.sender].push(newCampaign);
}
function getCampaignsByAddress(address creator) public view returns (Campaign memory) {
return campaigns[creator];
}
}
As i understand, the first option suppose to use more storage space to store the whole contract instance.
However, for both options createCampaign cost (remix estimation) is the same +- 660000 gas.
Additionally, getCampaignsByAddress with the return type Campaign strangely returns only addresses instead of full instances (so i suppose only the address is stored).
Question: what difference does it make to use option #1 or #2?
solidity solidity-best-practices
asked Dec 19 '18 at 19:51
user1935987user1935987
1597
add a comment |
new to solidity.
Trying to understand the better approach for using a mapping storage in factory contract.
2 options:
- Use
mapping(address => Contract)
- Use
mapping(address => address)
Sample factory:
contract CampaignFactory {
mapping(address => Campaign) campaigns;
function createCampaign(uint min_contrib) public {
Campaign newCampaign = new Campaign(min_contrib, msg.sender);
campaigns[msg.sender].push(newCampaign);
}
function getCampaignsByAddress(address creator) public view returns (Campaign memory) {
return campaigns[creator];
}
}
As i understand, the first option suppose to use more storage space to store the whole contract instance.
However, for both options createCampaign cost (remix estimation) is the same +- 660000 gas.
Additionally, getCampaignsByAddress with the return type Campaign strangely returns only addresses instead of full instances (so i suppose only the address is stored).
Question: what difference does it make to use option #1 or #2?
solidity solidity-best-practices
asked Dec 19 '18 at 19:51
user1935987user1935987
1597
add a comment |
new to solidity.
Trying to understand the better approach for using a mapping storage in factory contract.
2 options:
- Use
mapping(address => Contract)
- Use
mapping(address => address)
Sample factory:
contract CampaignFactory {
mapping(address => Campaign) campaigns;
function createCampaign(uint min_contrib) public {
Campaign newCampaign = new Campaign(min_contrib, msg.sender);
campaigns[msg.sender].push(newCampaign);
}
function getCampaignsByAddress(address creator) public view returns (Campaign memory) {
return campaigns[creator];
}
}
As i understand, the first option suppose to use more storage space to store the whole contract instance.
However, for both options createCampaign cost (remix estimation) is the same +- 660000 gas.
Additionally, getCampaignsByAddress with the return type Campaign strangely returns only addresses instead of full instances (so i suppose only the address is stored).
Question: what difference does it make to use option #1 or #2?
solidity solidity-best-practices
asked Dec 19 '18 at 19:51
user1935987user1935987
1597
new to solidity.
Trying to understand the better approach for using a mapping storage in factory contract.
2 options:
- Use
mapping(address => Contract)
- Use
mapping(address => address)
Sample factory:
contract CampaignFactory {
mapping(address => Campaign) campaigns;
function createCampaign(uint min_contrib) public {
Campaign newCampaign = new Campaign(min_contrib, msg.sender);
campaigns[msg.sender].push(newCampaign);
}
function getCampaignsByAddress(address creator) public view returns (Campaign memory) {
return campaigns[creator];
}
}
As i understand, the first option suppose to use more storage space to store the whole contract instance.
However, for both options createCampaign cost (remix estimation) is the same +- 660000 gas.
Additionally, getCampaignsByAddress with the return type Campaign strangely returns only addresses instead of full instances (so i suppose only the address is stored).
Question: what difference does it make to use option #1 or #2?
solidity solidity-best-practices
solidity solidity-best-practices
asked Dec 19 '18 at 19:51
user1935987user1935987
1597
asked Dec 19 '18 at 19:51
user1935987user1935987
1597
asked Dec 19 '18 at 19:51
user1935987user1935987
1597
asked Dec 19 '18 at 19:51
user1935987user1935987
1597
asked Dec 19 '18 at 19:51
user1935987user1935987
1597
1597
add a comment |
add a comment |
1 Answer
1
active
oldest
votes
There's no difference except that you'll get more type checking help from the Solidity compiler if you use Campaign.
In both cases, as you noted, the only thing stored is an address. Using the address type just means the compiler can't help you if you accidentally try to store a non-Campaign in your array.
So my advice is to use Campaign.
answered Dec 19 '18 at 20:25
smarxsmarx
18k1718
add a comment |
Your Answer
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "642"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fethereum.stackexchange.com%2fquestions%2f64341%2fsolidity-0-5-0-factory-pattern-mapping-apprach%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
There's no difference except that you'll get more type checking help from the Solidity compiler if you use Campaign.
In both cases, as you noted, the only thing stored is an address. Using the address type just means the compiler can't help you if you accidentally try to store a non-Campaign in your array.
So my advice is to use Campaign.
answered Dec 19 '18 at 20:25
smarxsmarx
18k1718
add a comment |
There's no difference except that you'll get more type checking help from the Solidity compiler if you use Campaign.
In both cases, as you noted, the only thing stored is an address. Using the address type just means the compiler can't help you if you accidentally try to store a non-Campaign in your array.
So my advice is to use Campaign.
answered Dec 19 '18 at 20:25
smarxsmarx
18k1718
add a comment |
There's no difference except that you'll get more type checking help from the Solidity compiler if you use Campaign.
In both cases, as you noted, the only thing stored is an address. Using the address type just means the compiler can't help you if you accidentally try to store a non-Campaign in your array.
So my advice is to use Campaign.
answered Dec 19 '18 at 20:25
smarxsmarx
18k1718
There's no difference except that you'll get more type checking help from the Solidity compiler if you use Campaign.
In both cases, as you noted, the only thing stored is an address. Using the address type just means the compiler can't help you if you accidentally try to store a non-Campaign in your array.
So my advice is to use Campaign.
answered Dec 19 '18 at 20:25
smarxsmarx
18k1718
answered Dec 19 '18 at 20:25
smarxsmarx
18k1718
answered Dec 19 '18 at 20:25
smarxsmarx
18k1718
answered Dec 19 '18 at 20:25
smarxsmarx
18k1718
18k1718
add a comment |
add a comment |
Thanks for contributing an answer to Ethereum Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fethereum.stackexchange.com%2fquestions%2f64341%2fsolidity-0-5-0-factory-pattern-mapping-apprach%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
