Krdytkyu

I'm writing a data logger application that reads live variable data from an embedded device and shows them to the user in the GUI.

I created a static class named DataBase that keeps all the variables in the LiveVariableDatabase and have methods to add samples, add/delete variables etc.

/* DataBase.cs file */



public class Var_t

{

    public string name;

    public UInt32 addr;

    public byte size;

    public List<byte> samples; //variable read values

};



static class DataBase

{                

    public static List<Var_t> LiveVariableDatabase = new List<Var_t>();



    public static bool AddNewVariable(Var_t var)

    {

        LiveVariableDatabase.Add(var);  



        //check successfull

        return updateSucceed;

    }



    public static bool DeleteVariable(Var_t var)

    {

        LiveVariableDatabase.Remove(var);  



        //check successfull

        return updateSucceed;

    }



    public static bool AddVarSample(int index, byte value)

    {

        LiveVariableDatabase[index].samples.Add(value);



        //check successfull

        return addSucceed;

    }

}

I need to access this LiveVariableDatabase from different classes and use the methods to make changes in the variables. I want to have only one instance of this class since all of the variables will be stored in this database. So I used a static class but I'm a beginner in C# and I normally use global variables for this kind of requirement in C. So I couldn't be sure defining everything as static is a good way of implementation. Because I want to have only one instance of DataBase but if I declare this class as static I don't need to create an instance of it, I just call the methods and the variables in different forms like:

This:

/* WatchWindowForm.cs file */



private void WatchWindowForm_FormClosing(object sender, FormClosingEventArgs e)

{

    for (int i = 0; i < watchTable.RowCount; i++)

    {

        string varName = watchTable.GetControlFromPosition(0, i).Text;

        Var_t watchVar = DataBase.LiveVariableDatabase.Find(x => x.name == varName);



        DataBase.DeleteVariable(watchVar);

    }

}

And the other,

/* ScopeWindowForm.cs file */



//Add a variable 

private void bt_addVar_Click(object sender, EventArgs e)

{          

    //TODO: o isimde var zaten varsa!

    foreach (Series s in chart1.Series)

    {

        if (s.Name == tb_varName.Text)

        {

            MessageBox.Show("You already have this variable added to the database!", "Error", MessageBoxButtons.OK, MessageBoxIcon.Error);

            return;

        }

    }



    Var_t var = new Var_t();



    var.addr = Convert.ToUInt32(tb_varAddr.Text, 16);

    var.size = Convert.ToByte(tb_varSize.Text, 10);

    var.name = tb_varName.Text;



    DataBase.AddVariable(var);

}

Is this a good way to use static class in this kind of necessity?