Prevent quote expansion in user-made function [duplicate]












1
















This question already has an answer here:




  • Why does my shell script choke on whitespace or other special characters?

    4 answers



  • When is double-quoting necessary?

    1 answer




I have the following bash function :



tg() {

  git add -A && git commit -m $1 && git push

}


But it seems not to work :



$ tg "create index for users"

error: pathspec 'index' did not match any file(s) known to git.

error: pathspec 'for' did not match any file(s) known to git.

error: pathspec 'users' did not match any file(s) known to git.


Obviously, the problem is that the quote was expanded and my middle command was read as git commit -m create index for users rather than git commit -m "create index for users"



What did I do wrong ? How can I fix this ?






bash quoting







share|improve this question















marked as duplicate by ilkkachu bash
Users with the  bash badge can single-handedly close bash questions as duplicates and reopen them as needed.

StackExchange.ready(function() {
if (StackExchange.options.isMobile) return;

$('.dupe-hammer-message-hover:not(.hover-bound)').each(function() {
var $hover = $(this).addClass('hover-bound'),
$msg = $hover.siblings('.dupe-hammer-message');

$hover.hover(
function() {
$hover.showInfoMessage('', {
messageElement: $msg.clone().show(),
transient: false,
position: { my: 'bottom left', at: 'top center', offsetTop: -7 },
dismissable: false,
relativeToBody: true
});
},
function() {
StackExchange.helpers.removeMessages();
}
);
});
});
 Jan 2 at 10:41


This question has been asked before and already has an answer. If those answers do not fully address your question, please ask a new question.














  • 1





    Also: mywiki.wooledge.org/WordSplitting

    – ilkkachu
    Jan 2 at 10:47
















1
















This question already has an answer here:




  • Why does my shell script choke on whitespace or other special characters?

    4 answers



  • When is double-quoting necessary?

    1 answer




I have the following bash function :



tg() {

  git add -A && git commit -m $1 && git push

}


But it seems not to work :



$ tg "create index for users"

error: pathspec 'index' did not match any file(s) known to git.

error: pathspec 'for' did not match any file(s) known to git.

error: pathspec 'users' did not match any file(s) known to git.


Obviously, the problem is that the quote was expanded and my middle command was read as git commit -m create index for users rather than git commit -m "create index for users"



What did I do wrong ? How can I fix this ?






bash quoting







share|improve this question















marked as duplicate by ilkkachu bash
Users with the  bash badge can single-handedly close bash questions as duplicates and reopen them as needed.

StackExchange.ready(function() {
if (StackExchange.options.isMobile) return;

$('.dupe-hammer-message-hover:not(.hover-bound)').each(function() {
var $hover = $(this).addClass('hover-bound'),
$msg = $hover.siblings('.dupe-hammer-message');

$hover.hover(
function() {
$hover.showInfoMessage('', {
messageElement: $msg.clone().show(),
transient: false,
position: { my: 'bottom left', at: 'top center', offsetTop: -7 },
dismissable: false,
relativeToBody: true
});
},
function() {
StackExchange.helpers.removeMessages();
}
);
});
});
 Jan 2 at 10:41


This question has been asked before and already has an answer. If those answers do not fully address your question, please ask a new question.














  • 1





    Also: mywiki.wooledge.org/WordSplitting

    – ilkkachu
    Jan 2 at 10:47














1












1








1









This question already has an answer here:




  • Why does my shell script choke on whitespace or other special characters?

    4 answers



  • When is double-quoting necessary?

    1 answer




I have the following bash function :



tg() {

  git add -A && git commit -m $1 && git push

}


But it seems not to work :



$ tg "create index for users"

error: pathspec 'index' did not match any file(s) known to git.

error: pathspec 'for' did not match any file(s) known to git.

error: pathspec 'users' did not match any file(s) known to git.


Obviously, the problem is that the quote was expanded and my middle command was read as git commit -m create index for users rather than git commit -m "create index for users"



What did I do wrong ? How can I fix this ?






bash quoting







share|improve this question

















This question already has an answer here:




  • Why does my shell script choke on whitespace or other special characters?

    4 answers



  • When is double-quoting necessary?

    1 answer




I have the following bash function :



tg() {

  git add -A && git commit -m $1 && git push

}


But it seems not to work :



$ tg "create index for users"

error: pathspec 'index' did not match any file(s) known to git.

error: pathspec 'for' did not match any file(s) known to git.

error: pathspec 'users' did not match any file(s) known to git.


Obviously, the problem is that the quote was expanded and my middle command was read as git commit -m create index for users rather than git commit -m "create index for users"



What did I do wrong ? How can I fix this ?





This question already has an answer here:




  • Why does my shell script choke on whitespace or other special characters?

    4 answers



  • When is double-quoting necessary?

    1 answer







bash quoting




bash quoting






share|improve this question















share|improve this question













share|improve this question




share|improve this question








edited Jan 2 at 10:35









Rui F Ribeiro

40.7k1479137




40.7k1479137










asked Jan 2 at 9:53









Ewan DelanoyEwan Delanoy

1627




1627




marked as duplicate by ilkkachu bash
Users with the  bash badge can single-handedly close bash questions as duplicates and reopen them as needed.

StackExchange.ready(function() {
if (StackExchange.options.isMobile) return;

$('.dupe-hammer-message-hover:not(.hover-bound)').each(function() {
var $hover = $(this).addClass('hover-bound'),
$msg = $hover.siblings('.dupe-hammer-message');

$hover.hover(
function() {
$hover.showInfoMessage('', {
messageElement: $msg.clone().show(),
transient: false,
position: { my: 'bottom left', at: 'top center', offsetTop: -7 },
dismissable: false,
relativeToBody: true
});
},
function() {
StackExchange.helpers.removeMessages();
}
);
});
});
 Jan 2 at 10:41


This question has been asked before and already has an answer. If those answers do not fully address your question, please ask a new question.









marked as duplicate by ilkkachu bash
Users with the  bash badge can single-handedly close bash questions as duplicates and reopen them as needed.

StackExchange.ready(function() {
if (StackExchange.options.isMobile) return;

$('.dupe-hammer-message-hover:not(.hover-bound)').each(function() {
var $hover = $(this).addClass('hover-bound'),
$msg = $hover.siblings('.dupe-hammer-message');

$hover.hover(
function() {
$hover.showInfoMessage('', {
messageElement: $msg.clone().show(),
transient: false,
position: { my: 'bottom left', at: 'top center', offsetTop: -7 },
dismissable: false,
relativeToBody: true
});
},
function() {
StackExchange.helpers.removeMessages();
}
);
});
});
 Jan 2 at 10:41


This question has been asked before and already has an answer. If those answers do not fully address your question, please ask a new question.










  • 1





    Also: mywiki.wooledge.org/WordSplitting

    – ilkkachu
    Jan 2 at 10:47














  • 1





    Also: mywiki.wooledge.org/WordSplitting

    – ilkkachu
    Jan 2 at 10:47








1




1





Also: mywiki.wooledge.org/WordSplitting

– ilkkachu
Jan 2 at 10:47





Also: mywiki.wooledge.org/WordSplitting

– ilkkachu
Jan 2 at 10:47










1 Answer
1






active

oldest

votes


















4














Double quote the expansion $1:



tg() {

  git add -A &&

  git commit -m "$1" &&

  git push

}


By not quoting $1, the shell will split its value on whitespaces (the contents of $IFS) and the resulting words will additionally undergo filename globbing.



Related:




  • Why does my shell script choke on whitespace or other special characters?

  • When is double-quoting necessary?

  • Security implications of forgetting to quote a variable in bash/POSIX shells






share|improve this answer


























  • Thx for your help. I'm confused here : isn't "$1" supposed to be a "heredoc" string and variables inside it are supposed to be expanded ? For example, in the shell echo "$MYVAR" is equivalent to echo $MYVAR ?

    – Ewan Delanoy
    Jan 2 at 10:03






  • 2





    @EwanDelanoy You are not using any here-document in your code. A here-document is written utility <<TAG and terminated by TAG (TAG can be any string). It's a form of redirection. echo $var and echo "$var" are not equivalent for the same reasons as I mentioned in my answer. Test with var=*. When it comes to variable expansions and quoting, $var and $1 behaves the same.

    – Kusalananda
    Jan 2 at 10:06













  • Got it, thx. I'll try your solution a few times and accept it if it works.

    – Ewan Delanoy
    Jan 2 at 10:08








  • 1





    @EwanDelanoy If there's only one "word" and no whitespaces, then echo "$MYVAR" and echo $MYVAR will have same output. But if you have hello world then "$MYVAR" is treated as single word, $MYVAR is split into two words. In this case, this is trivial. If you do ls $MYVAR it can give you file not found if you're looking for hello world file, because ls will look for two files, hello and world, but ls "$MYVAR" will show you the file hello world.

    – Sergiy Kolodyazhnyy
    Jan 2 at 10:09








  • 1





    @SergiyKolodyazhnyy That first sentence is true only given that the word contains no filename globbing characters, and that IFS has the default value.

    – Kusalananda
    Jan 2 at 10:13




















1 Answer
1






active

oldest

votes








1 Answer
1






active

oldest

votes









active

oldest

votes






active

oldest

votes









4














Double quote the expansion $1:



tg() {

  git add -A &&

  git commit -m "$1" &&

  git push

}


By not quoting $1, the shell will split its value on whitespaces (the contents of $IFS) and the resulting words will additionally undergo filename globbing.



Related:




  • Why does my shell script choke on whitespace or other special characters?

  • When is double-quoting necessary?

  • Security implications of forgetting to quote a variable in bash/POSIX shells






share|improve this answer


























  • Thx for your help. I'm confused here : isn't "$1" supposed to be a "heredoc" string and variables inside it are supposed to be expanded ? For example, in the shell echo "$MYVAR" is equivalent to echo $MYVAR ?

    – Ewan Delanoy
    Jan 2 at 10:03






  • 2





    @EwanDelanoy You are not using any here-document in your code. A here-document is written utility <<TAG and terminated by TAG (TAG can be any string). It's a form of redirection. echo $var and echo "$var" are not equivalent for the same reasons as I mentioned in my answer. Test with var=*. When it comes to variable expansions and quoting, $var and $1 behaves the same.

    – Kusalananda
    Jan 2 at 10:06













  • Got it, thx. I'll try your solution a few times and accept it if it works.

    – Ewan Delanoy
    Jan 2 at 10:08








  • 1





    @EwanDelanoy If there's only one "word" and no whitespaces, then echo "$MYVAR" and echo $MYVAR will have same output. But if you have hello world then "$MYVAR" is treated as single word, $MYVAR is split into two words. In this case, this is trivial. If you do ls $MYVAR it can give you file not found if you're looking for hello world file, because ls will look for two files, hello and world, but ls "$MYVAR" will show you the file hello world.

    – Sergiy Kolodyazhnyy
    Jan 2 at 10:09








  • 1





    @SergiyKolodyazhnyy That first sentence is true only given that the word contains no filename globbing characters, and that IFS has the default value.

    – Kusalananda
    Jan 2 at 10:13


















4














Double quote the expansion $1:



tg() {

  git add -A &&

  git commit -m "$1" &&

  git push

}


By not quoting $1, the shell will split its value on whitespaces (the contents of $IFS) and the resulting words will additionally undergo filename globbing.



Related:




  • Why does my shell script choke on whitespace or other special characters?

  • When is double-quoting necessary?

  • Security implications of forgetting to quote a variable in bash/POSIX shells






share|improve this answer


























  • Thx for your help. I'm confused here : isn't "$1" supposed to be a "heredoc" string and variables inside it are supposed to be expanded ? For example, in the shell echo "$MYVAR" is equivalent to echo $MYVAR ?

    – Ewan Delanoy
    Jan 2 at 10:03






  • 2





    @EwanDelanoy You are not using any here-document in your code. A here-document is written utility <<TAG and terminated by TAG (TAG can be any string). It's a form of redirection. echo $var and echo "$var" are not equivalent for the same reasons as I mentioned in my answer. Test with var=*. When it comes to variable expansions and quoting, $var and $1 behaves the same.

    – Kusalananda
    Jan 2 at 10:06













  • Got it, thx. I'll try your solution a few times and accept it if it works.

    – Ewan Delanoy
    Jan 2 at 10:08








  • 1





    @EwanDelanoy If there's only one "word" and no whitespaces, then echo "$MYVAR" and echo $MYVAR will have same output. But if you have hello world then "$MYVAR" is treated as single word, $MYVAR is split into two words. In this case, this is trivial. If you do ls $MYVAR it can give you file not found if you're looking for hello world file, because ls will look for two files, hello and world, but ls "$MYVAR" will show you the file hello world.

    – Sergiy Kolodyazhnyy
    Jan 2 at 10:09








  • 1





    @SergiyKolodyazhnyy That first sentence is true only given that the word contains no filename globbing characters, and that IFS has the default value.

    – Kusalananda
    Jan 2 at 10:13
















4












4








4







Double quote the expansion $1:



tg() {

  git add -A &&

  git commit -m "$1" &&

  git push

}


By not quoting $1, the shell will split its value on whitespaces (the contents of $IFS) and the resulting words will additionally undergo filename globbing.



Related:




  • Why does my shell script choke on whitespace or other special characters?

  • When is double-quoting necessary?

  • Security implications of forgetting to quote a variable in bash/POSIX shells






share|improve this answer















Double quote the expansion $1:



tg() {

  git add -A &&

  git commit -m "$1" &&

  git push

}


By not quoting $1, the shell will split its value on whitespaces (the contents of $IFS) and the resulting words will additionally undergo filename globbing.



Related:




  • Why does my shell script choke on whitespace or other special characters?

  • When is double-quoting necessary?

  • Security implications of forgetting to quote a variable in bash/POSIX shells







share|improve this answer














share|improve this answer



share|improve this answer








edited Jan 2 at 10:11

























answered Jan 2 at 9:58









KusalanandaKusalananda

133k17254417




133k17254417













  • Thx for your help. I'm confused here : isn't "$1" supposed to be a "heredoc" string and variables inside it are supposed to be expanded ? For example, in the shell echo "$MYVAR" is equivalent to echo $MYVAR ?

    – Ewan Delanoy
    Jan 2 at 10:03






  • 2





    @EwanDelanoy You are not using any here-document in your code. A here-document is written utility <<TAG and terminated by TAG (TAG can be any string). It's a form of redirection. echo $var and echo "$var" are not equivalent for the same reasons as I mentioned in my answer. Test with var=*. When it comes to variable expansions and quoting, $var and $1 behaves the same.

    – Kusalananda
    Jan 2 at 10:06













  • Got it, thx. I'll try your solution a few times and accept it if it works.

    – Ewan Delanoy
    Jan 2 at 10:08








  • 1





    @EwanDelanoy If there's only one "word" and no whitespaces, then echo "$MYVAR" and echo $MYVAR will have same output. But if you have hello world then "$MYVAR" is treated as single word, $MYVAR is split into two words. In this case, this is trivial. If you do ls $MYVAR it can give you file not found if you're looking for hello world file, because ls will look for two files, hello and world, but ls "$MYVAR" will show you the file hello world.

    – Sergiy Kolodyazhnyy
    Jan 2 at 10:09








  • 1





    @SergiyKolodyazhnyy That first sentence is true only given that the word contains no filename globbing characters, and that IFS has the default value.

    – Kusalananda
    Jan 2 at 10:13





















  • Thx for your help. I'm confused here : isn't "$1" supposed to be a "heredoc" string and variables inside it are supposed to be expanded ? For example, in the shell echo "$MYVAR" is equivalent to echo $MYVAR ?

    – Ewan Delanoy
    Jan 2 at 10:03






  • 2





    @EwanDelanoy You are not using any here-document in your code. A here-document is written utility <<TAG and terminated by TAG (TAG can be any string). It's a form of redirection. echo $var and echo "$var" are not equivalent for the same reasons as I mentioned in my answer. Test with var=*. When it comes to variable expansions and quoting, $var and $1 behaves the same.

    – Kusalananda
    Jan 2 at 10:06













  • Got it, thx. I'll try your solution a few times and accept it if it works.

    – Ewan Delanoy
    Jan 2 at 10:08








  • 1





    @EwanDelanoy If there's only one "word" and no whitespaces, then echo "$MYVAR" and echo $MYVAR will have same output. But if you have hello world then "$MYVAR" is treated as single word, $MYVAR is split into two words. In this case, this is trivial. If you do ls $MYVAR it can give you file not found if you're looking for hello world file, because ls will look for two files, hello and world, but ls "$MYVAR" will show you the file hello world.

    – Sergiy Kolodyazhnyy
    Jan 2 at 10:09








  • 1





    @SergiyKolodyazhnyy That first sentence is true only given that the word contains no filename globbing characters, and that IFS has the default value.

    – Kusalananda
    Jan 2 at 10:13



















Thx for your help. I'm confused here : isn't "$1" supposed to be a "heredoc" string and variables inside it are supposed to be expanded ? For example, in the shell echo "$MYVAR" is equivalent to echo $MYVAR ?

– Ewan Delanoy
Jan 2 at 10:03





Thx for your help. I'm confused here : isn't "$1" supposed to be a "heredoc" string and variables inside it are supposed to be expanded ? For example, in the shell echo "$MYVAR" is equivalent to echo $MYVAR ?

– Ewan Delanoy
Jan 2 at 10:03




2




2





@EwanDelanoy You are not using any here-document in your code. A here-document is written utility <<TAG and terminated by TAG (TAG can be any string). It's a form of redirection. echo $var and echo "$var" are not equivalent for the same reasons as I mentioned in my answer. Test with var=*. When it comes to variable expansions and quoting, $var and $1 behaves the same.

– Kusalananda
Jan 2 at 10:06







@EwanDelanoy You are not using any here-document in your code. A here-document is written utility <<TAG and terminated by TAG (TAG can be any string). It's a form of redirection. echo $var and echo "$var" are not equivalent for the same reasons as I mentioned in my answer. Test with var=*. When it comes to variable expansions and quoting, $var and $1 behaves the same.

– Kusalananda
Jan 2 at 10:06















Got it, thx. I'll try your solution a few times and accept it if it works.

– Ewan Delanoy
Jan 2 at 10:08







Got it, thx. I'll try your solution a few times and accept it if it works.

– Ewan Delanoy
Jan 2 at 10:08






1




1





@EwanDelanoy If there's only one "word" and no whitespaces, then echo "$MYVAR" and echo $MYVAR will have same output. But if you have hello world then "$MYVAR" is treated as single word, $MYVAR is split into two words. In this case, this is trivial. If you do ls $MYVAR it can give you file not found if you're looking for hello world file, because ls will look for two files, hello and world, but ls "$MYVAR" will show you the file hello world.

– Sergiy Kolodyazhnyy
Jan 2 at 10:09







@EwanDelanoy If there's only one "word" and no whitespaces, then echo "$MYVAR" and echo $MYVAR will have same output. But if you have hello world then "$MYVAR" is treated as single word, $MYVAR is split into two words. In this case, this is trivial. If you do ls $MYVAR it can give you file not found if you're looking for hello world file, because ls will look for two files, hello and world, but ls "$MYVAR" will show you the file hello world.

– Sergiy Kolodyazhnyy
Jan 2 at 10:09






1




1





@SergiyKolodyazhnyy That first sentence is true only given that the word contains no filename globbing characters, and that IFS has the default value.

– Kusalananda
Jan 2 at 10:13







@SergiyKolodyazhnyy That first sentence is true only given that the word contains no filename globbing characters, and that IFS has the default value.

– Kusalananda
Jan 2 at 10:13





-

Popular posts from this blog

Ellipse (mathématiques)

Image
Pour les articles homonymes, voir Ellipse. L'ellipse est le lieu des points dont la somme des distances à deux points fixes, dits foyers, est constante. Section du cône ou projection du cercle. En géométrie, une ellipse est une courbe plane fermée obtenue par l’intersection d’un cône de révolution avec un plan, à condition que celui-ci coupe l'axe de rotation du cône ou du cylindre : c'est une conique d'excentricité strictement comprise entre 0 et 1. On peut également la définir comme le lieu des points dont la somme des distances à deux points fixes, dits foyers, est constante (sa construction par la méthode du jardinier est très simple). Dans la vie courante, l’ellipse est la forme qu'on perçoit en regardant un cercle en perspective, ou la figure formée par l’ombre d'un disque sur une surface plane. On retrouve aussi, en première approximation [ 1 ] , des ellipses dans les trajectoires des corps célestes (planètes, comètes ou satellites arti...
Read more

Quarter-circle Tiles

Image
up vote 0 down vote favorite I have $99$ identical square tiles, each with a quarter-circle drawn on it like this: [asy] size(1.5cm); draw(Arc((2,0),1,90,180),red+1); draw((0,0)--(2,0)--(2,2)--(0,2)--(0,0)); [/asy] When I arrange the tiles in a $9times 11$ rectangular grid, each with a random orientation, what is the expected value of the number of full circles I form? I think this problem has to do with finding the chance any given 2x2 square has a circle, but I can't find it. expected-value share | cite | improve this question asked Nov 20 at 15:03 6minecraftninja 1 2 ...
Read more

Mont Emei

Image
Mont Emei.mw-parser-output .entete.map{background-image:url("//upload.wikimedia.org/wikipedia/commons/7/7a/Picto_infobox_map.png")} Vue du sommet Wanfo du mont Emei Géographie Altitude 3 099  m , Wanfo Coordonnées 29° 31′ 11″ nord, 103° 19′ 57″ est Administration Pays   Chine Province Sichuan Ville-préfecture Leshan Géolocalisation sur la carte : Sichuan Mont Emei Géolocalisation sur la carte : Chine Mont Emei modifier   Paysage panoramique du mont Emei, incluant le paysage panoramique du grand Bouddha de Leshan *   Patrimoine mondial de l'UNESCO Passerelle en bois sur le versant ouest Pays   Chine Subdivision Sichuan Type Mixte Critères (iv) (vi) (x) Superficie 15 400 ha Numéro d’identification 779 Zone géographique Asie et Pacifique  ** Année d’inscription 1996 (20 e session) * Descriptif officiel UNESCO ** Classification géog...
Read more