Making a certificate signing request, with validation
up vote
0
down vote
favorite
I have a function that takes a handful of parameters and I want to ensure the data being passed to it is the correct data and types. Below is a sample function that I wrote to ensure the parameters are correct. How does this practice look and can it be improved on?
def self.create_csr(key, cn, dc)
raise Stdlib::Error.new('No suitable key was provided') if key.nil? or ! key.is_a?(OpenSSL::PKey::RSA)
raise Stdlib::Error.new('No CN was supplied to the certificate') if cn.nil? or ! cn.is_a?(String)
raise Stdlib::Error.new('No DC array was supplied to the certificate') if dc.nil? or ! dc.is_a?(String)
dclist = String.new
dc.each do |d|
dclist = dclist + "/DC=#{d}"
end
name = OpenSSL::X509::Name.parse "CN=#{cn}#{dclist}"
csr = OpenSSL::X509::Request.new
csr.version = 0
csr.subject = name
csr.public_key = key.public_key
csr.sign key, OpenSSL::Digest::SHA1.new
end
ruby validation openssl ssl
add a comment |
up vote
0
down vote
favorite
I have a function that takes a handful of parameters and I want to ensure the data being passed to it is the correct data and types. Below is a sample function that I wrote to ensure the parameters are correct. How does this practice look and can it be improved on?
def self.create_csr(key, cn, dc)
raise Stdlib::Error.new('No suitable key was provided') if key.nil? or ! key.is_a?(OpenSSL::PKey::RSA)
raise Stdlib::Error.new('No CN was supplied to the certificate') if cn.nil? or ! cn.is_a?(String)
raise Stdlib::Error.new('No DC array was supplied to the certificate') if dc.nil? or ! dc.is_a?(String)
dclist = String.new
dc.each do |d|
dclist = dclist + "/DC=#{d}"
end
name = OpenSSL::X509::Name.parse "CN=#{cn}#{dclist}"
csr = OpenSSL::X509::Request.new
csr.version = 0
csr.subject = name
csr.public_key = key.public_key
csr.sign key, OpenSSL::Digest::SHA1.new
end
ruby validation openssl ssl
add a comment |
up vote
0
down vote
favorite
up vote
0
down vote
favorite
I have a function that takes a handful of parameters and I want to ensure the data being passed to it is the correct data and types. Below is a sample function that I wrote to ensure the parameters are correct. How does this practice look and can it be improved on?
def self.create_csr(key, cn, dc)
raise Stdlib::Error.new('No suitable key was provided') if key.nil? or ! key.is_a?(OpenSSL::PKey::RSA)
raise Stdlib::Error.new('No CN was supplied to the certificate') if cn.nil? or ! cn.is_a?(String)
raise Stdlib::Error.new('No DC array was supplied to the certificate') if dc.nil? or ! dc.is_a?(String)
dclist = String.new
dc.each do |d|
dclist = dclist + "/DC=#{d}"
end
name = OpenSSL::X509::Name.parse "CN=#{cn}#{dclist}"
csr = OpenSSL::X509::Request.new
csr.version = 0
csr.subject = name
csr.public_key = key.public_key
csr.sign key, OpenSSL::Digest::SHA1.new
end
ruby validation openssl ssl
I have a function that takes a handful of parameters and I want to ensure the data being passed to it is the correct data and types. Below is a sample function that I wrote to ensure the parameters are correct. How does this practice look and can it be improved on?
def self.create_csr(key, cn, dc)
raise Stdlib::Error.new('No suitable key was provided') if key.nil? or ! key.is_a?(OpenSSL::PKey::RSA)
raise Stdlib::Error.new('No CN was supplied to the certificate') if cn.nil? or ! cn.is_a?(String)
raise Stdlib::Error.new('No DC array was supplied to the certificate') if dc.nil? or ! dc.is_a?(String)
dclist = String.new
dc.each do |d|
dclist = dclist + "/DC=#{d}"
end
name = OpenSSL::X509::Name.parse "CN=#{cn}#{dclist}"
csr = OpenSSL::X509::Request.new
csr.version = 0
csr.subject = name
csr.public_key = key.public_key
csr.sign key, OpenSSL::Digest::SHA1.new
end
ruby validation openssl ssl
ruby validation openssl ssl
edited 8 hours ago
200_success
128k15149412
128k15149412
asked 9 hours ago
jacksonecac
1284
1284
add a comment |
add a comment |
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f209676%2fmaking-a-certificate-signing-request-with-validation%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
active
oldest
votes
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f209676%2fmaking-a-certificate-signing-request-with-validation%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown