Is it possible to compare two binary trees in less than O(n log n) time?












6














I wrote a java routine to compare 2 binary trees. I am looking for better algorithms that run in less time. 



 public class TreeNode {

  int val;

  TreeNode left;

  TreeNode right;

  TreeNode(int x) { val = x; }

 }



 class Solution {

  public boolean isSameTree(TreeNode p, TreeNode q) {



    if  ( p == null && q==null)

        return true;



    if (p == null || q == null) 

        return false;



    if ( (p.val == q.val) && isSameTree(p.left, q.left) && 

      isSameTree(p.right, q.right))

        return true;

    else 

        return false;  

   }   

  }


My code takes O(n log n) time.



How to approach reducing the time required?






java algorithm time-complexity binary-tree







share|improve this question
























  • If you happen to have a size variable at the base of the structure, compare that first.
    – Boann
    2 hours ago
















6














I wrote a java routine to compare 2 binary trees. I am looking for better algorithms that run in less time. 



 public class TreeNode {

  int val;

  TreeNode left;

  TreeNode right;

  TreeNode(int x) { val = x; }

 }



 class Solution {

  public boolean isSameTree(TreeNode p, TreeNode q) {



    if  ( p == null && q==null)

        return true;



    if (p == null || q == null) 

        return false;



    if ( (p.val == q.val) && isSameTree(p.left, q.left) && 

      isSameTree(p.right, q.right))

        return true;

    else 

        return false;  

   }   

  }


My code takes O(n log n) time.



How to approach reducing the time required?






java algorithm time-complexity binary-tree







share|improve this question
























  • If you happen to have a size variable at the base of the structure, compare that first.
    – Boann
    2 hours ago














6












6








6


1





I wrote a java routine to compare 2 binary trees. I am looking for better algorithms that run in less time. 



 public class TreeNode {

  int val;

  TreeNode left;

  TreeNode right;

  TreeNode(int x) { val = x; }

 }



 class Solution {

  public boolean isSameTree(TreeNode p, TreeNode q) {



    if  ( p == null && q==null)

        return true;



    if (p == null || q == null) 

        return false;



    if ( (p.val == q.val) && isSameTree(p.left, q.left) && 

      isSameTree(p.right, q.right))

        return true;

    else 

        return false;  

   }   

  }


My code takes O(n log n) time.



How to approach reducing the time required?






java algorithm time-complexity binary-tree







share|improve this question















I wrote a java routine to compare 2 binary trees. I am looking for better algorithms that run in less time. 



 public class TreeNode {

  int val;

  TreeNode left;

  TreeNode right;

  TreeNode(int x) { val = x; }

 }



 class Solution {

  public boolean isSameTree(TreeNode p, TreeNode q) {



    if  ( p == null && q==null)

        return true;



    if (p == null || q == null) 

        return false;



    if ( (p.val == q.val) && isSameTree(p.left, q.left) && 

      isSameTree(p.right, q.right))

        return true;

    else 

        return false;  

   }   

  }


My code takes O(n log n) time.



How to approach reducing the time required?






java algorithm time-complexity binary-tree




java algorithm time-complexity binary-tree






share|improve this question















share|improve this question













share|improve this question




share|improve this question








edited 3 hours ago









nullpointer

43.8k1093179




43.8k1093179










asked 4 hours ago









Louise

311




311












  • If you happen to have a size variable at the base of the structure, compare that first.
    – Boann
    2 hours ago


















  • If you happen to have a size variable at the base of the structure, compare that first.
    – Boann
    2 hours ago
















If you happen to have a size variable at the base of the structure, compare that first.
– Boann
2 hours ago




If you happen to have a size variable at the base of the structure, compare that first.
– Boann
2 hours ago












1 Answer
1






active

oldest

votes


















7














The current runtime of your approach is actually O(n), where n should be the number of nodes of the tree with lesser(or if they're equal) nodes.



Also, note to compare all the values of a data structure you would have to visit all of them and that is the runtime you could achieve and not reduce further. In the current case, at the worst, you would have to visit all the nodes of the smaller tree and hence O(n).



Hence any other approach though might help you with conditional optimization, your current solution has an optimal runtime which cannot be reduced further.






share|improve this answer



















  • 2




    In fact ... it is O(n) worst case. The best case is O(1).
    – Stephen C
    3 hours ago











Your Answer






StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");

StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});

function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});


}
});














draft saved

draft discarded


















StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f54067216%2fis-it-possible-to-compare-two-binary-trees-in-less-than-on-log-n-time%23new-answer', 'question_page');
}
);

Post as a guest















Required, but never shown

























1 Answer
1






active

oldest

votes








1 Answer
1






active

oldest

votes









active

oldest

votes






active

oldest

votes









7














The current runtime of your approach is actually O(n), where n should be the number of nodes of the tree with lesser(or if they're equal) nodes.



Also, note to compare all the values of a data structure you would have to visit all of them and that is the runtime you could achieve and not reduce further. In the current case, at the worst, you would have to visit all the nodes of the smaller tree and hence O(n).



Hence any other approach though might help you with conditional optimization, your current solution has an optimal runtime which cannot be reduced further.






share|improve this answer



















  • 2




    In fact ... it is O(n) worst case. The best case is O(1).
    – Stephen C
    3 hours ago
















7














The current runtime of your approach is actually O(n), where n should be the number of nodes of the tree with lesser(or if they're equal) nodes.



Also, note to compare all the values of a data structure you would have to visit all of them and that is the runtime you could achieve and not reduce further. In the current case, at the worst, you would have to visit all the nodes of the smaller tree and hence O(n).



Hence any other approach though might help you with conditional optimization, your current solution has an optimal runtime which cannot be reduced further.






share|improve this answer



















  • 2




    In fact ... it is O(n) worst case. The best case is O(1).
    – Stephen C
    3 hours ago














7












7








7






The current runtime of your approach is actually O(n), where n should be the number of nodes of the tree with lesser(or if they're equal) nodes.



Also, note to compare all the values of a data structure you would have to visit all of them and that is the runtime you could achieve and not reduce further. In the current case, at the worst, you would have to visit all the nodes of the smaller tree and hence O(n).



Hence any other approach though might help you with conditional optimization, your current solution has an optimal runtime which cannot be reduced further.






share|improve this answer














The current runtime of your approach is actually O(n), where n should be the number of nodes of the tree with lesser(or if they're equal) nodes.



Also, note to compare all the values of a data structure you would have to visit all of them and that is the runtime you could achieve and not reduce further. In the current case, at the worst, you would have to visit all the nodes of the smaller tree and hence O(n).



Hence any other approach though might help you with conditional optimization, your current solution has an optimal runtime which cannot be reduced further.







share|improve this answer














share|improve this answer



share|improve this answer








edited 2 hours ago









ruakh

124k13197251




124k13197251










answered 3 hours ago









nullpointer

43.8k1093179




43.8k1093179








  • 2




    In fact ... it is O(n) worst case. The best case is O(1).
    – Stephen C
    3 hours ago














  • 2




    In fact ... it is O(n) worst case. The best case is O(1).
    – Stephen C
    3 hours ago








2




2




In fact ... it is O(n) worst case. The best case is O(1).
– Stephen C
3 hours ago




In fact ... it is O(n) worst case. The best case is O(1).
– Stephen C
3 hours ago


















draft saved

draft discarded




















































Thanks for contributing an answer to Stack Overflow!


  • Please be sure to answer the question. Provide details and share your research!

But avoid …



  • Asking for help, clarification, or responding to other answers.

  • Making statements based on opinion; back them up with references or personal experience.


To learn more, see our tips on writing great answers.





Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


Please pay close attention to the following guidance:


  • Please be sure to answer the question. Provide details and share your research!

But avoid …



  • Asking for help, clarification, or responding to other answers.

  • Making statements based on opinion; back them up with references or personal experience.


To learn more, see our tips on writing great answers.




draft saved


draft discarded














StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f54067216%2fis-it-possible-to-compare-two-binary-trees-in-less-than-on-log-n-time%23new-answer', 'question_page');
}
);

Post as a guest















Required, but never shown





















































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown

































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown







-

Popular posts from this blog

Quarter-circle Tiles

Image
up vote 0 down vote favorite I have $99$ identical square tiles, each with a quarter-circle drawn on it like this: [asy] size(1.5cm); draw(Arc((2,0),1,90,180),red+1); draw((0,0)--(2,0)--(2,2)--(0,2)--(0,0)); [/asy] When I arrange the tiles in a $9times 11$ rectangular grid, each with a random orientation, what is the expected value of the number of full circles I form? I think this problem has to do with finding the chance any given 2x2 square has a circle, but I can't find it. expected-value share | cite | improve this question asked Nov 20 at 15:03 6minecraftninja 1 2
Read more

build a pushdown automaton that recognizes the reverse language of a given pushdown automaton?

Image
0 I think it's similiar to NFAs. I replace the finite states of the given automaton for start-states for my new automaton. I do it with $epsilon$ -transition from the start state to the actual finite states of the given automaton. The start state of the given automaton will be my accepting(finite) state of my new one. All transitions will be reversed of course to recognize the reversed word. But how do I have to change the stack of the pushdown automaton? That's tricky. formal-languages automata context-free-grammar share | cite | improve this question edited Nov 29 '18 at 14:20 joee
Read more

Mont Emei

Image
Mont Emei.mw-parser-output .entete.map{background-image:url("//upload.wikimedia.org/wikipedia/commons/7/7a/Picto_infobox_map.png")} Vue du sommet Wanfo du mont Emei Géographie Altitude 3 099  m , Wanfo Coordonnées 29° 31′ 11″ nord, 103° 19′ 57″ est Administration Pays   Chine Province Sichuan Ville-préfecture Leshan Géolocalisation sur la carte : Sichuan Mont Emei Géolocalisation sur la carte : Chine Mont Emei modifier   Paysage panoramique du mont Emei, incluant le paysage panoramique du grand Bouddha de Leshan *   Patrimoine mondial de l'UNESCO Passerelle en bois sur le versant ouest Pays   Chine Subdivision Sichuan Type Mixte Critères (iv) (vi) (x) Superficie 15 400 ha Numéro d’identification 779 Zone géographique Asie et Pacifique  ** Année d’inscription 1996 (20 e session) * Descriptif officiel UNESCO ** Classification géog
Read more